PLGMAG2V2-765: Add PHPStan tests (#723)

Author: vinodsowdagar

.github/workflows/phpstan.yml

@@ -0,0 +1,39 @@
+name: Magento 2 PHPStan
+on: [push]
+
+jobs:
+  phpstan:
+    name: PHPStan
+    runs-on: ubuntu-latest
+    steps:
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '7.4'
+        env:
+          COMPOSER_AUTH_JSON: |
+            {
+              "http-basic": {
+                "repo.magento.com": {
+                  "username": "${{ secrets.MAGENTO_MARKETPLACE_USERNAME }}",
+                  "password": "${{ secrets.MAGENTO_MARKETPLACE_PASSWORD }}"
+                }
+              }
+            }
+      - uses: actions/checkout@v4
+      - name: Create composer project
+        run: composer create-project --no-install --no-interaction --no-plugins --repository-url=https://repo-magento-mirror.fooman.co.nz/ magento/project-community-edition:2.4.5-p8 /home/runner/work/magento
+      - name: Add composer plugins
+        working-directory: /home/runner/work/magento
+        run: composer config --no-plugins allow-plugins true
+      - name: Add module to composer
+        working-directory: /home/runner/work/magento
+        run: composer require multisafepay/magento2-core --no-update --no-interaction
+      - name: Install composer dependencies
+        working-directory: /home/runner/work/magento
+        run: composer install --no-interaction
+      - name: Move repository content
+        run: cp -r -f ${{ github.workspace }}/* /home/runner/work/magento/vendor/multisafepay/magento2-core
+      - name: Run PHPStan
+        working-directory: /home/runner/work/magento
+        run: vendor/bin/phpstan analyse -c vendor/multisafepay/magento2-core/phpstan.neon --error-format github

Model/Method/GenericAdapter.php

@@ -585,7 +585,7 @@ public function canSale(): bool
     /**
      * @inheritdoc
      */
-    public function sale(InfoInterface $payment, float $amount): ?ResultInterface
+    public function sale(InfoInterface $payment, float $amount)
     {
         $this->executeCommand(
             'sale',

phpstan.neon

@@ -0,0 +1,14 @@
+parameters:
+    level: 0
+    errorFormat: github
+    paths:
+        - .
+    excludePaths:
+        - etc
+        - Test
+        - view
+        - Model/Api/Builder/OrderRequestBuilder/ShoppingCartBuilder/CustomTotalBuilder.php
+        - Util/ThirdPartyPluginsUtil.php
+    ignoreErrors:
+        - '#Parameter \$\w+ of method [a-zA-Z0-9\\_]+::__construct\(\) has invalid type .*Factory.*#'
+        - '#Method [a-zA-Z0-9\\_]+::getExtensionAttributes\(\) has invalid return type .*OrderPaymentExtension.*#'