Merge pull request #121 from Muetze42/development

Muetze42 · web-flow · commit d1f0e90ab103 · 2025-09-03T18:32:36.000+02:00
fix: prevent errors on HasSlugTrait
diff --git a/src/Traits/Models/HasSlugTrait.php b/src/Traits/Models/HasSlugTrait.php
@@ -25,7 +25,8 @@ public static function bootHasSlugTrait(): void
     {
         static::saving(function (Model $model) {
             foreach ((new static())->sluggable as $attribute) {
-                if (in_array($attribute, (new static())->getFillable()) || ! is_null($model->{$attribute})) {
+                /** @noinspection NotOptimalIfConditionsInspection */
+                if ($model->hasAttribute($attribute) && ! is_null($model->{$attribute})) {
                     $model->slug = Str::slug($model->{$attribute});
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,8 @@ public static function bootHasSlugTrait(): void`
`25`	`25`	`{`
`26`	`26`	`static::saving(function (Model $model) {`
`27`	`27`	`foreach ((new static())->sluggable as $attribute) {`
`28`		`- if (in_array($attribute, (new static())->getFillable()) \|\| ! is_null($model->{$attribute})) {`
	`28`	`+ /** @noinspection NotOptimalIfConditionsInspection */`
	`29`	`+ if ($model->hasAttribute($attribute) && ! is_null($model->{$attribute})) {`
`29`	`30`	`$model->slug = Str::slug($model->{$attribute});`
`30`	`31`	`}`
`31`	`32`	`}`