Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the EntityLogicalName attribute on an entity for the logical name #10

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

aa-dit-yuh
Copy link
Contributor

@aa-dit-yuh aa-dit-yuh commented Jan 9, 2024

Reading the EntityLogicalName member of an entity class is a magic that only works for classes written using early/late bound generators.

When writing an entity class by hand, it is not obvious that the class must have a member named EntityLogicalName.

Read the EntityLogicalName attribute on an entity for the logical name seems like a much saner implementation.

Verified that all passing tests still pass after this refactor.

@MscrmTools MscrmTools merged commit fee51d7 into MscrmTools:master Jan 15, 2024
1 check passed
@aa-dit-yuh aa-dit-yuh deleted the read-class-attr branch January 16, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants