Skip to content

Commit

Permalink
Clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
MrScautHD committed Jul 5, 2024
1 parent a0e3292 commit d5d0d12
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 11 deletions.
2 changes: 1 addition & 1 deletion src/Sparkle/CSharp/Effects/Types/PbrEffect.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

namespace Sparkle.CSharp.Effects.Types;

// TODO: Optimize it more!
// TODO: Optimize it more! (FIX IT)
public class PbrEffect : Effect {

public GlVersion GlVersion { get; private set; }
Expand Down
10 changes: 5 additions & 5 deletions src/Sparkle/CSharp/Effects/Types/PixelizerEffect.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ public class PixelizerEffect : Effect {
public int ResolutionLoc { get; private set; }
public int PixelSizeLoc { get; private set; }

private Vector2 PixelSize;
public Vector2 PixelSize;

private Vector2 _pixelSize;
private Vector2 _oldPixelSize;

/// <summary>
/// Constructor for creating a PixelizerEffect object.
Expand All @@ -37,9 +37,9 @@ public override void Apply(Material? material = default) {
this.UpdateResolution();
}

if (RayMath.Vector2Equals(this.PixelSize, this._pixelSize) != 1) {
this.Shader.SetValue(this.PixelSizeLoc, this._pixelSize, ShaderUniformDataType.Vec2);
this._pixelSize = this.PixelSize;
if (RayMath.Vector2Equals(this.PixelSize, this._oldPixelSize) != 1) {
this.Shader.SetValue(this.PixelSizeLoc, this._oldPixelSize, ShaderUniformDataType.Vec2);
this._oldPixelSize = this.PixelSize;
}
}

Expand Down
5 changes: 1 addition & 4 deletions src/Sparkle/CSharp/Registries/Registry.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,12 @@ namespace Sparkle.CSharp.Registries;

public abstract class Registry : Disposable {

public bool HasLoaded { get; private set; }
public bool HasInitialized { get; private set; }

/// <summary>
/// Used for loading resources.
/// </summary>
protected internal virtual void Load(ContentManager content) {
this.HasLoaded = true;
}
protected internal virtual void Load(ContentManager content) { }

/// <summary>
/// Used for Initializes objects.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

namespace Sparkle.CSharp.Rendering.Models;

// TODO: ADD GPU ANIMATIONS
public class ModelAnimationPlayer {

private Model _model;
Expand Down
1 change: 0 additions & 1 deletion src/Sparkle/Sparkle.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
<!-- Libraries -->
<ItemGroup>
<PackageReference Include="Box2D.NetStandard" Version="2.4.7-alpha" />
<PackageReference Include="FFMpegCore" Version="5.1.0" />
<PackageReference Include="Jitter2" Version="2.3.1" />
<PackageReference Include="LibNoise" Version="0.2.0" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
Expand Down

0 comments on commit d5d0d12

Please sign in to comment.