Reorder menu screens #2074
Closed
Reorder menu screens #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
|
Good stuff, video looks great :-) I noted this looks to hit that switch where the music restarts? Any easy way to avoid that? I figured "Next" would be a good new caption for the button that continues to preview/config. That seems like a perfect spot to also scan for and list custom hot keys for the active mix of models? Hitting some oddities though. First time through on Core (with an existing config.cfg which also enabled Sample) I started without an inventory (no items nor able to open inventory with Went back to main menu, picked the Cities template, started, got to where the music stopped but then the game stalled with this in the log: Something wrong with the environment setup? Deleted my existing config.cfg just in case, started again, same issue in Core. Back to main menu, picked JoshariasSurvival this time. Took a while to load the preview screen, restarted the music, hit play, and made it into the game. Got a pile of reflection errors on startup though: Still couldn't pick up stuff (can break stuff fine). Opening the inventory showed the extension JS adds but not the base inventory. |
This was referenced Dec 20, 2015
Closed
|
I suspect that this is due the fact that a fresh context is derived from from And is your comment to #1743 still valid or is it now possible to prevent the unloading of assets when changing the module environment? |
|
Also pinging @flo for Context reference |
|
Could not the context created for the preview be the same like the one that gets used ingame? (I haven't reviewed the patch, so I might be off) |
|
Yes, I would think so, too. I'm unsure how that instance would be passed/derived from the menu one and whether it should be disposed when returning back to the main menu. |
10 tasks
Cervator
added
Topic: Architecture
|
Bump. The RC1 build now hits a non-crash error on attempting a preview on Cities. Hopefully we can move forward with this refactor and get it fixed up :-) @msteiger - ping! |
|
I think that this need some more polishing before it can be merged. So I suggest shipping alpha without it. Will try to have a more thorough look over the next weekend. |
Closed
|
@msteiger what shall we do with this PR? It's now about a year old. Do you still plan to polish it and bring it in? |
|
Thanks for the reminder. Actually, yes, I haven't forgotten - it's still on my todo list. It might take a little more time (1-2 weeks?) before I can dig into it again. We can close it and I'll reopen as soon as it's ready if you like. |
11 tasks
|
Will reopen as soon as I find the time to dig this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2068
In the next step, more game content could be loaded already for the preview screen. This should enable previews of TtA and Cities.
Video showcase: https://youtu.be/SKfROUg3aVg