BUG: Manual labelling not opening in Version: 1.0.0.1

[ElsaOakes]

Describe the issue:

I have just installed the newest version of Suite2p. I have processed a recording and opened the stat.npy file successfully however, when I try and open the manual labelling function from the GUI (File -> Manual labelling) no window opens and I get the following error.

Example input dataset used to reproduce the issue:

No response

Error message:

Traceback (most recent call last):
  File "C:\Users\lab\.conda\envs\suite2p\Lib\site-packages\suite2p\gui\menus.py", line 67, in <lambda>
    parent.manual.triggered.connect(lambda: manual_label(parent))
                                            ^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\lab\.conda\envs\suite2p\Lib\site-packages\suite2p\gui\menus.py", line 191, in manual_label
    MW = drawroi.ROIDraw(parent)
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\lab\.conda\envs\suite2p\Lib\site-packages\suite2p\gui\drawroi.py", line 220, in __init__
    self.masked_images = self.normalize_img_add_masks()
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\lab\.conda\envs\suite2p\Lib\site-packages\suite2p\gui\drawroi.py", line 301, in normalize_img_add_masks
    settings["xrange"][1]] = self.parent.ops["meanImg"][
    ^^^^^^^^
AttributeError: 'MainWindow' object has no attribute 'settings'

Version information:

suite2p v1.0.0.1

Context for the issue:

This is currently preventing me from using the most updated version of suite2p for my analysis despite the ROI output being superior to previous versions.

[Guihte]

I hit the same issue locally. In suite2p/gui/drawroi.py, ROIDraw.normalize_img_add_masks() is trying to use settings["xrange"] / settings["yrange"], but settings is not defined there and the GUI MainWindow does not have parent.settings.

The fix I used was to read the display ranges from parent.ops instead, with a fallback to the full meanImg shape when xrange / yrange are missing. In short:

ops = parent.ops
Ly, Lx = np.asarray(ops["meanImg"]).shape
yrange = ops.get("yrange", [0, Ly])
xrange = ops.get("xrange", [0, Lx])

It should work until an official Suite2P fix is released.

[chriski777]

Hi @ElsaOakes, could you try pulling the changes present in PR #1228? The PR should contain changes that address this issue.