fix(logs): handle non-string values in search to prevent runtime crash #993
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the motia Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The LogsPage component crashes at runtime when the backend sends a log
with
msg,traceId, orstepthat is not a string. Since the UIcalls
.toLowerCase()during filtering, any non-string value (null,number, object, undefined) immediately triggers a TypeError.
This PR normalizes these fields to empty strings before applying
.toLowerCase(), ensuring the filtering logic never crashes even whenthe backend sends unexpected data types.
Related Issues
Fixes #992
Type of Change
Checklist
Screenshots (if applicable)
Additional Context