-
Notifications
You must be signed in to change notification settings - Fork 846
Fixes/build fails on windows due to unix shell commands sidd #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/community-contributions
Are you sure you want to change the base?
Conversation
…uild-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
|
@sidgaikwad is attempting to deploy a commit to the motia Team on Vercel. A member of the Team first needs to authorize it. |
0baadc2 to
66132e8
Compare
66132e8 to
20b6de2
Compare
20b6de2 to
33fdb36
Compare
|
Thank you, I plan to test it later today on a windows machine |
yeah thanks |
…uild-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
…-sidd' of https://github.com/sidgaikwad/motia into Fixes/Build-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
…uild-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
…uild-Fails-on-Windows-Due-to-Unix-Shell-Commands-sidd
|
hey @sidgaikwad , Sergio is looking into this - sorry for some delay in this review. |
…Dev#787) This commit fixes Issue MotiaDev#787 where the build process fails on Windows due to Unix-specific shell commands that are not available in Windows CMD or PowerShell. Changes Made: 1. **Root package.json**: - Added cross-platform dependencies: rimraf, cpy-cli, mkdirp - Updated clean script to use rimraf instead of rm -rf 2. **packages/core/package.json**: - Replaced mkdir -p with mkdirp - Replaced cp commands with cpy - Replaced rm -rf with rimraf - All move:* and build scripts now cross-platform compatible 3. **packages/workbench/package.json**: - Replaced rm -rf with rimraf - Replaced sh post-build.sh with node post-build.js 4. **packages/workbench/post-build.js** (NEW): - Cross-platform replacement for post-build.sh - Implements file/directory copying using Node.js fs module - Performs text replacement in HTML files - Works on Windows, macOS, and Linux 5. **playground/package.json**: - Replaced rm -rf with rimraf in clean script 6. **Documentation**: - ISSUE_787_ANALYSIS.md: Detailed problem analysis - ISSUE_787_FIX_SUMMARY.md: Complete fix documentation - fix-windows-scripts.js: Automated fix script for remaining packages Impact: - Windows developers can now build without WSL or Git Bash - Consistent behavior across all operating systems - Improved CI/CD compatibility - Better developer experience Testing: All scripts should now work on Windows PowerShell, CMD, and Unix shells. Related: MotiaDev#787, MotiaDev#788 Co-authored-by: PR MotiaDev#788 analysis
|
Hey @sidgaikwad 👋 How's it going? I know you reached out to me recently. I checked with the team and they're going to review this PR and merge if everything pass successfully. Sorry for delay caused. |
|
Hey @sidgaikwad, please resolve the conflicts so we can merge this. Thanks. |
PR: Make
packages/coreBuild Cross-PlatformDescription
This PR updates the
packages/corebuild scripts to be cross-platform usingrimrafandcpy-cliinstead of Unix-specific commands.Changes
rimrafandcpy-clias dev dependencies:packages/core/package.jsonscripts:How to Test
Verify that:
distfolder is created correctly.Screenshots:
Fixes: #787
Notes