Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encryption: the whole file or only text in file? #38

Open
patanric opened this issue Jul 4, 2017 · 3 comments
Open

Encryption: the whole file or only text in file? #38

patanric opened this issue Jul 4, 2017 · 3 comments

Comments

@patanric
Copy link
Contributor

patanric commented Jul 4, 2017

(this is a discussion, I cannot apply labels to issues)

Passwords and unser names have to be stored as secure as possible. What are the pros and cons to encrypt the whole file and decrypt it at login time. What ideas do you have?

@rkulesza9
Copy link

Hi there, I'm new to open source and thought this was a nice simple project to jump into. I think encrypting the whole file is fine - after all an instance of this program is focused around one user. the amount of data that is being encrypted wouldn't be concerning; I can't see efficiency or overhead or anything else being much of an issue. Java has a nice cryptography library. we could use an AES encryption using a salt-and-hash of the application-login data as a key. That would be secure.

@joshhazelhurst123
Copy link

I think encrypt the whole file and the text in the files. The user will have to have a password to log into the file. Log in with a username and password for a specific user, e.g. admin, SSmith, BAdams. Only show the passwords to authenticated users. Do not show unnecessary passwords to users who do not have current permissions, admin grants permissions to users etc. I have used AES password manager. It will be good to have other alternative password manager programs to use, for security reasons of course. You can use different encryption methods, MD5, sha1, encryption, etc.
Pro's, more secure I believe (if you encrypt the file and the password text in the file it will be more difficult to crack).
cons, will use more file space in megabytes.
Depending on how far you want to go with this piece of software, cryptography is big business, fingerprint scanners, facial scanners etc.

@Eyremba
Copy link

Eyremba commented Aug 26, 2017

A few suggestions:

  • SHA-3 with a custom amount of iterations as hash for the password
  • Rijndael (AES) 256 for the database encryption. Encrypt the whole database.
  • Because the Java crypto lib uses by default only AES-128, use your own implementation of AES with 256 Bit support.
  • Keep the passwords encrypted in the process memory when they are not used/shown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants