Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressbar #12

Closed
krlos2011 opened this issue Feb 20, 2018 · 8 comments · Fixed by #17
Closed

Progressbar #12

krlos2011 opened this issue Feb 20, 2018 · 8 comments · Fixed by #17

Comments

@krlos2011
Copy link

Hello, your branch is being of great help for my project. Thank you for your support.
There are a simple bug that we have found.

Bug description:

The type property not works properly and is writing .progress-bar-{{type}} at .progress-bar element instead of .bg-{{type}}

Steps to reproduce the issue:

<uib-progressbar value="50" type="danger" class="mb-2"><b>50%</b></uib-progressbar>

A simple workaround

<uib-progressbar value="50" class="mb-2"><b class="bg-danger">50%</b></uib-progressbar>

Version of Angular, UIBS, and Bootstrap

Angular: 1.6.7

UIBS: 3.0.2

Bootstrap: 4.0.0

@Morgul
Copy link
Owner

Morgul commented Feb 21, 2018

Thanks for catching that. If you'd like to try your hand at a merge request, I'd gladly take it. Otherwise, I should get to this fix this week, along with a new version release.

@YuraDubensky
Copy link

I have fixed tests and created a pull-request #18.

@YuraDubensky
Copy link

@Morgul Please verify. I am really looking forward to new release as we need fixes for dropdowns and tootip for our production.

@Morgul
Copy link
Owner

Morgul commented Mar 5, 2018

I will do my best to take a look at #18 today, if I can. One way or the other, I can promise a new release by the end of the week, how's that sound?

(I'm shooting for earlier than that, just to be clear. But no matter what, I'll release what we've got by the end of the week.)

@YuraDubensky
Copy link

@Morgul Sounds good. Thanks

@YuraDubensky
Copy link

@Morgul Hey there, how is it going with release?

@Morgul
Copy link
Owner

Morgul commented Mar 13, 2018

@YuraDubensky released v3.0.3

@YuraDubensky
Copy link

@Morgul You rock! Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants