Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bower Support #11

Open
DavoBR opened this issue Feb 18, 2018 · 6 comments
Open

Add Bower Support #11

DavoBR opened this issue Feb 18, 2018 · 6 comments

Comments

@DavoBR
Copy link

DavoBR commented Feb 18, 2018

No description provided.

@DavoBR DavoBR changed the title How install from bower? How to install from bower? Feb 18, 2018
@Morgul
Copy link
Owner

Morgul commented Feb 18, 2018

Here's some good news/bad news.

Bad News

Bower is not officially supported by ui-bootstrap4. Since it no longer recommends being used for new projects, and I have limited resources, I have no intention of maintaining support for it.

Good News

It should just work. With some minor caveats.

$ bower install morgul/ui-bootstrap4

However, there's no dist folder. Instead, the files you're looking for are under bower_components/ui-bootstrap4/docs. That folder contains a copy of every version, ever. Needless to say, it's a little overkill, but it'll work.

If you (or anyone else) wants to improve that situation and make it less bloatedr, I will absolutely take merge requests.

@Morgul Morgul closed this as completed Feb 18, 2018
@Zelarith
Copy link

Hi,
I'm also working with bower.
I tried

$ bower install ui-bootstrap4

And it successfully added the directory to my bower.
The problem though is that my brunch-config.js doesn't seem to be able to pick it up, as it doesn't have any bower.json to indicate it where to pick the main file.

Anyone facing this issue with a handy workaround?

@Morgul
Copy link
Owner

Morgul commented Jan 21, 2019

If this is really a need, I'll take a merge request to add bower.json.

@Zelarith
Copy link

That'd be really nice :)

While bower is deprecated it is still maintained, and I see a lot of projects still using it.

Of course, new projects should use Yarn over Bower, and I see how one could think an old project would be unlikely to come without ui-bootstrap integrated.

As a matter of fact, my project already had it, but the wrong version.
It had Bootstrap CSS 4.1.3, with UI-Bootstrap 2.0.5 (wich was built for Bootstrap CSS 3.3.7).
Some classes were updated between these 2 versions of Bootstrap CSS, and, as a result, we can't go back to Bootstrap CSS 3.3.7, but some of the modules of UI-Bootstrap aren't working properly either.

The only thing to do is to upgrade to UI-Bootstrap4, but we are stuck with bower...
Either that or we need to import it as a JS asset, wich is kinda ugly.

@Morgul
Copy link
Owner

Morgul commented Jan 21, 2019

@Zelarith Yeah, when I started this project I was in a similar boat, but we did the upgrade to a new build system (We've gone through three since the bower days, TBH)... and even though it's not hard, I do know what kind of push back you can get on those large changes to "legacy" products. I'm really, really trying to encourage people to use this the only way the maintainer does, but alas, such is the nature of this particular project.

I need to just be a little bit more open, and let the people who use bower deal with issues with bower, if they come up. Kinda hate doing that, but it's better than a "no" in this case.

@Morgul Morgul changed the title How to install from bower? Add Bower Support Jan 21, 2019
@Morgul
Copy link
Owner

Morgul commented Jan 21, 2019

Reopening this to track.

@Morgul Morgul reopened this Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants