Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Normalization #88

Closed
seporterfield opened this issue May 29, 2024 · 2 comments · Fixed by #167
Closed

URL Normalization #88

seporterfield opened this issue May 29, 2024 · 2 comments · Fixed by #167
Assignees

Comments

@seporterfield
Copy link
Collaborator

From the linked article originally in a comment in #85
Django docs on normalizing URLs

Both of these options are meant to normalize URLs. The philosophy is that each URL should exist in one, and only one, place. Technically a URL foo.com/bar is distinct from foo.com/bar/ – a search-engine indexer would treat them as separate URLs – so it’s best practice to normalize URLs.

Since SEO is important, shall we change this to True?
Maybe add PREPEND_WWW too?

@Monstarrrr
Copy link
Owner

Monstarrrr commented May 29, 2024

I did add APPEND_SLASH (on feat/1_auth) before but couldn't get expected result so I implemented a solution on the front-end which is not ideal.
Let's go over this during the meeting.

@seporterfield
Copy link
Collaborator Author

seporterfield commented Jun 12, 2024

I did add APPEND_SLASH (on feat/1_auth)

Setting it to false makes Django not normalize URLs to have an ending slash

Setting it to true would help in some cases, for example the confusion caused in #166

@purple-void purple-void linked a pull request Jun 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants