Skip to content

Force reinstallation when self-hosted Runner is not installed but is registered with Github Runners. #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2025
Merged

Force reinstallation when self-hosted Runner is not installed but is registered with Github Runners. #234

merged 3 commits into from
Jul 25, 2025

Conversation

rickyn-croesus
Copy link
Contributor

@rickyn-croesus rickyn-croesus commented Jun 25, 2025 •
edited
Loading

Description

Force reinstallation when self-hosted Runner is not installed but is registered with Github Runners.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (Github Actions Workflow, Documentation etc.)

How Has This Been Tested?

Internal Github Workflow that:

  • Install agents
  • check that agents are registered and online
  • Uninstall agents
  • check that agents are unregistered

this used to fail across runs before the fixes.

Fixes

  • detect if a runner with the same name is registered but offline and force reinstallation
  • use a query parameter instead of a body form parameter (the latter does not seem to work and returns the default API 30 results instead of role defaults 100 results.

@rickyn-croesus rickyn-croesus mentioned this pull request Jun 30, 2025
Open
@rickyn-croesus
Copy link
Contributor Author

rickyn-croesus commented Jul 22, 2025 •
edited
Loading

@MonolithProjects any changes needed to get this PR merged?

@MonolithProjects MonolithProjects self-assigned this Jul 25, 2025
@MonolithProjects MonolithProjects added the enhancement New feature or request label Jul 25, 2025
MonolithProjects
MonolithProjects approved these changes Jul 25, 2025
View reviewed changes
Copy link
Owner

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@MonolithProjects MonolithProjects merged commit ed4b47a into MonolithProjects:master Jul 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonolithProjects MonolithProjects MonolithProjects approved these changes

Assignees

@MonolithProjects MonolithProjects

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickyn-croesus @MonolithProjects