Fix loops module cell throwing a traceback.

Remove --allow-errors flag from build.

Author: pansapiens

build.sh

@@ -5,13 +5,13 @@ INPUT_DIR="workshops/docs/modules/notebooks"
 OUT_DIR="workshops/docs/modules"
 TEMPLATE_DIR="workshops/docs/modules/notebooks/nbconvert_templates"
 
-# We need to allow errors when executing since there are examples that
-# intentionally elicit a traceback.
-# TODO: If we move those examples into Markdown cells we can remove
-# --allow-errors and better test notebooks at build time
-#
+# We allow errors (--allow-errors) when executing to catch and broken examples.
+# Any example that requires printing a traceback should be moved into a
+# Markdown example cell so that code is displayed by not executed.
+
 # ggplot/plotnine cells are sometimes slow, so we increase the default timeout
-EXECUTE="--execute --allow-errors --ExecutePreprocessor.timeout=240"
+# EXECUTE="--execute --allow-errors --ExecutePreprocessor.timeout=240"
+EXECUTE="--execute --ExecutePreprocessor.timeout=240"
 
 generate_html='no'
 generate_instructor_notes='no'

workshops/docs/modules/loops.md

@@ -111,6 +111,7 @@ While this works, it's a bad approach for two reasons:
 
 
 
+Running:
 
 ```python
 word = 'tin'
@@ -120,29 +121,22 @@ print(word[2])
 print(word[3])
 ```
 
-<pre class="output">
-<div class="output_label">output</div>
-<code class="text">
-t
-i
-n
 
-</code>
-</pre>
 
 
-    ---------------------------------------------------------------------------
 
-    IndexError                                Traceback (most recent call last)
-
-    <ipython-input-3-e59d5eac5430> in <module>()
-          3 print(word[1])
-          4 print(word[2])
-    ----> 5 print(word[3])
-    
-
-    IndexError: string index out of range
+Gives the error:
 
+```
+---------------------------------------------------------------------------
+IndexError                                Traceback (most recent call last)
+<ipython-input-4-e59d5eac5430> in <module>()
+      3 print(word[1])
+      4 print(word[2])
+----> 5 print(word[3])
+
+IndexError: string index out of range
+```
 
 
 

workshops/docs/modules/notebooks/loops.ipynb

@@ -109,37 +109,36 @@
    ]
   },
   {
-   "cell_type": "code",
-   "execution_count": 4,
+   "cell_type": "markdown",
    "metadata": {},
-   "outputs": [
-    {
-     "name": "stdout",
-     "output_type": "stream",
-     "text": [
-      "t\n",
-      "i\n",
-      "n\n"
-     ]
-    },
-    {
-     "ename": "IndexError",
-     "evalue": "string index out of range",
-     "output_type": "error",
-     "traceback": [
-      "\u001b[0;31m---------------------------------------------------------------------------\u001b[0m",
-      "\u001b[0;31mIndexError\u001b[0m                                Traceback (most recent call last)",
-      "\u001b[0;32m<ipython-input-4-e59d5eac5430>\u001b[0m in \u001b[0;36m<module>\u001b[0;34m()\u001b[0m\n\u001b[1;32m      3\u001b[0m \u001b[0mprint\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0mword\u001b[0m\u001b[0;34m[\u001b[0m\u001b[0;36m1\u001b[0m\u001b[0;34m]\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[1;32m      4\u001b[0m \u001b[0mprint\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0mword\u001b[0m\u001b[0;34m[\u001b[0m\u001b[0;36m2\u001b[0m\u001b[0;34m]\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[0;32m----> 5\u001b[0;31m \u001b[0mprint\u001b[0m\u001b[0;34m(\u001b[0m\u001b[0mword\u001b[0m\u001b[0;34m[\u001b[0m\u001b[0;36m3\u001b[0m\u001b[0;34m]\u001b[0m\u001b[0;34m)\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[0m",
-      "\u001b[0;31mIndexError\u001b[0m: string index out of range"
-     ]
-    }
-   ],
    "source": [
+    "Running:\n",
+    "\n",
+    "```python\n",
     "word = 'tin'\n",
     "print(word[0])\n",
     "print(word[1])\n",
     "print(word[2])\n",
-    "print(word[3])"
+    "print(word[3])\n",
+    "```"
+   ]
+  },
+  {
+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "Gives the error:\n",
+    "\n",
+    "```\n",
+    "---------------------------------------------------------------------------\n",
+    "IndexError                                Traceback (most recent call last)\n",
+    "<ipython-input-4-e59d5eac5430> in <module>()\n",
+    "      3 print(word[1])\n",
+    "      4 print(word[2])\n",
+    "----> 5 print(word[3])\n",
+    "\n",
+    "IndexError: string index out of range\n",
+    "```"
    ]
   },
   {