Treeshakable controllers (#96)

* Allow for treeshakable controllers

* Cleanup

* Cleanup

* Address comments

Author: michaeltintiuc

package.json

@@ -76,7 +76,7 @@
     "vue": "^2.5.16",
     "vue-template-compiler": "^2.5.16",
     "vue-router": "^3.0.1",
-    "@ionic/core": "^4.6.0"
+    "@ionic/core": "^4.10.0"
   },
   "jestSonar": {
     "reportPath": "reports",

src/controllers/action-sheet-controller.ts

@@ -1,7 +1,13 @@
-export { ActionSheetController } from './action-sheet-controller';
-export { AlertController } from './alert-controller';
-export { LoadingController } from './loading-controller';
-export { MenuController } from './menu-controller';
-export { ModalController } from './modal-controller';
-export { PopoverController } from './popover-controller';
-export { ToastController } from './toast-controller';
+export {
+  actionSheetController,
+  alertController,
+  loadingController,
+  menuController,
+  toastController,
+  pickerController,
+} from '@ionic/core';
+import { modalController as _modalController } from './modal-controller';
+import { popoverController as _popoverController } from './popover-controller';
+
+export const modalController = _modalController();
+export const popoverController = _popoverController();

src/controllers/alert-controller.ts

@@ -1,20 +1,16 @@
-import { ModalOptions } from '@ionic/core';
-import { OverlayBaseController } from '../util';
+import Vue from 'vue';
+import { ModalOptions, modalController as _modalController } from '@ionic/core';
 import { VueDelegate } from './vue-delegate';
 
-export const CTRL = 'ion-modal-controller';
-export class ModalController extends OverlayBaseController<ModalOptions, HTMLIonModalElement> {
-
-  constructor(
-    private delegate: VueDelegate
-  ) {
-    super(CTRL);
-  }
-
-  create(opts: ModalOptions): Promise<HTMLIonModalElement> {
-    return super.create({
-      ...opts,
-      delegate: this.delegate
-    });
-  }
-}
+export const modalController = (delegate?: VueDelegate) => {
+  delegate = delegate || new VueDelegate(Vue);
+  return {
+    ..._modalController,
+    create(options: ModalOptions) {
+      return _modalController.create({
+        ...options,
+        delegate,
+      });
+    }
+  };
+};

src/controllers/index.ts

@@ -1,20 +1,16 @@
-import { PopoverOptions } from '@ionic/core';
-import { OverlayBaseController } from '../util';
+import Vue from 'vue';
+import { PopoverOptions, popoverController as _popoverController } from '@ionic/core';
 import { VueDelegate } from './vue-delegate';
 
-export const CTRL = 'ion-popover-controller';
-export class PopoverController extends OverlayBaseController<PopoverOptions, HTMLIonPopoverElement> {
-
-  constructor(
-    private delegate: VueDelegate
-  ) {
-    super(CTRL);
-  }
-
-  create(opts: PopoverOptions): Promise<HTMLIonPopoverElement> {
-    return super.create({
-      ...opts,
-      delegate: this.delegate
-    });
-  }
-}
+export const popoverController = (delegate?: VueDelegate) => {
+  delegate = delegate || new VueDelegate(Vue);
+  return {
+    ..._popoverController,
+    create(options: PopoverOptions) {
+      return _popoverController.create({
+        ...options,
+        delegate,
+      });
+    }
+  };
+};