Fix confusing error when XHR statusText is blank

msegado · msegado · commit 8b4dd4742099 · 2015-07-31T19:58:24.000-04:00
In the existing `Error(xhr.statusText + ': ' + url || 'XHR error')` implementation, the LHS of the OR is always truthy, so XHR failures with no statusText yield error messages like `: google.com`. This edit changes that to a slightly-less-cryptic `XHR error: status 0 "": http://google.com` (which yields useful results in a web search), or if there is a statusText, `XHR error: status 403 "Forbidden": http://mydomain.com/page`. (Feel free to just change it directly in the codebase instead of merging if you prefer different formatting, etc.)
diff --git a/src/system-fetch.js b/src/system-fetch.js
@@ -33,7 +33,7 @@
         fulfill(xhr.responseText);
       }
       function error() {
-        reject(new Error(xhr.statusText + ': ' + url || 'XHR error'));
+        reject(new Error('XHR error: status ' + xhr.status + ' "' + xhr.statusText + '": ' + url));
       }
 
       xhr.onreadystatechange = function () {

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@`
`33`	`33`	`fulfill(xhr.responseText);`
`34`	`34`	`}`
`35`	`35`	`function error() {`
`36`		`- reject(new Error(xhr.statusText + ': ' + url \|\| 'XHR error'));`
	`36`	`+ reject(new Error('XHR error: status ' + xhr.status + ' "' + xhr.statusText + '": ' + url));`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`xhr.onreadystatechange = function () {`