-
Notifications
You must be signed in to change notification settings - Fork 290
add launch_server and StartArgs #1119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @sufubao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the server's initialization and argument handling by introducing a dedicated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the server startup logic by introducing a launch_server function and centralizing configuration in the StartArgs dataclass. This is a positive change for code structure and maintainability. However, I've found a critical issue in api_server.py that will prevent the server from starting due to incorrect argument unpacking. I've also noted a minor point about including a deprecated argument in the StartArgs dataclass, which could be confusing.
lightllm/server/api_server.py
Outdated
| parser = make_argument_parser() | ||
| args = parser.parse_args() | ||
|
|
||
| launch_server(StartArgs(**args)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The argparse.Namespace object returned by parser.parse_args() cannot be unpacked directly into a dataclass constructor using **args. This will raise a TypeError because the keys of the namespace are not strings. You should convert the namespace to a dictionary using vars(args) before unpacking.
| launch_server(StartArgs(**args)) | |
| launch_server(StartArgs(**vars(args))) |
No description provided.