[WIP][app-builder] 实现分域功能 #422
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuayee
added
in: builder
XinLi-cyber
requested changes
Sep 4, 2025
| } | ||
| UserGroup userGroup = this.getUserGroup(username); | ||
| String currUserGroupId = userGroup.getId(); | ||
| for(String toBeVerifiedId : toBeVerifiedIds) { |
| UserGroup userGroup = this.getUserGroup(username); | ||
| String currUserGroupId = userGroup.getId(); | ||
| for(String toBeVerifiedId : toBeVerifiedIds) { | ||
| if (!(StringUtils.equals(toBeVerifiedId, "*") || StringUtils.equals(toBeVerifiedId, currUserGroupId))) { |
There was a problem hiding this comment.
这个for循环可以优化为stream，例如 return Arrays.stream(toBeVerifiedIds)
.allMatch(id -> Objects.equals(id, "*") || Objects.equals(id, currUserGroupId));
| Object[] paramValues = joinPoint.getArgs(); | ||
| Object value = null; | ||
| for (int i = 0; i < paramNames.length; i++) { | ||
| if (paramNames[i].equals(idKey)) { |
| String currentUserGroupId = this.domainDivisionService.getUserGroupId(); | ||
| boolean isCurrentGroup = StringUtils.equals(data.getUserGroupId(), currentUserGroupId); | ||
| boolean isAllGroup = StringUtils.equals(data.getUserGroupId(), "*"); | ||
| return !(isCurrentGroup || isAllGroup); |
There was a problem hiding this comment.
这里逻辑比较绕，建议前面取反，增加易读性
例如：
// 明确排除两种情况
boolean isAccessibleGroup = !StringUtils.equals(data.getUserGroupId(), currentUserGroupId);
boolean isNotWildcardGroup = !StringUtils.equals(data.getUserGroupId(), "*");;
return isAccessibleGroup && isNotWildcardGroup;
| * 向当前构建器中设置用户组唯一标识。 | ||
| * | ||
| * @param userGroupId 表示用户组唯一标识的 {@link String}。 | ||
| * @return 表示当前构建器的 {@link B}。 |
There was a problem hiding this comment.
这里没必要加link了吧？请确认是否可以跳转，是否有必要性。若可以的话，直接关闭该意见即可
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 相关问题 / Related Issue
Issue 链接 / Issue Link: #
📋 变更类型 / Type of Change
📝 变更目的 / Purpose of the Change
📋 主要变更 / Brief Changelog
🧪 验证变更 / Verifying this Change
测试步骤 / Test Steps
以下几种方式创建资源，对应查找资源时，会根据用户的用户组不同，可见性不同
（1）三种应用创建方式和应用查询
（2）表单上传和查询
（3）插件上传、查询和部署
（4）工具流创建
The following methods create resources. When searching for resources, visibility varies depending on the user's user group.
(1) Three application creation methods and application query
(2) Form upload and query
(3) Plugin upload, query, and deployment
(4) Tool flow creation
admin用户能够访问所有资源 / The admin user can access all resources
公共组资源能被所有用户访问 / Public group resources can be accessed by all users
如果用户创建了资源后，切换了组，则看不到之前组的信息 /
If a user switches groups after creating a resource, the previous group's information will not be visible.
测试覆盖 / Test Coverage
📸 截图 / Screenshots
✅ 贡献者检查清单 / Contributor Checklist
请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:
基本要求 / Basic Requirements:
代码质量 / Code Quality:
测试要求 / Testing Requirements:
mvn -B clean package -Dmaven.test.skip=true，npm install --force && npm run build:pro/ Basic checks passmvn clean install/ Unit tests pass文档和兼容性 / Documentation and Compatibility:
📋 附加信息 / Additional Notes
审查者注意事项 / Reviewer Notes: