Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version update #372

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Version update #372

merged 2 commits into from
Aug 9, 2023

Conversation

Monsurat-Onabajo
Copy link
Contributor

No description provided.

@Monsurat-Onabajo
Copy link
Contributor Author

hello, i tried merging but it seems i am not authorized to merge it

@pgleeson
Copy link
Member

hello, i tried merging but it seems i am not authorized to merge it

@Monsurat-Onabajo Which way did you try merging? This branch into development? It's just us on the core team that have permission to do that for now. And besides, it can't be merged yet, as the tests don't pass on 3.11.

All the relevant changes from development are here as previously requested on the other pull request, so thanks. However, there is one small change here too on the Installation.md file. It's only a minor change but I'm just flagging it to emphasise that for any pull request like this the changes should be the minimum requred for the purpose of the PR.

@Monsurat-Onabajo
Copy link
Contributor Author

Ok, i understand now. I will note the change, thank you

@kmantel
Copy link
Contributor

kmantel commented Jan 19, 2023

It looks like onnxruntime may not support 3.11 yet? See https://github.com/ModECI/MDF/actions/runs/3913971052/jobs/6690495742

ERROR: Ignored the following versions that require a different python version: 1.21.2 Requires-Python >=3.7,<3.11; 1.21.3 Requires-Python >=3.7,<3.11; 1.21.4 Requires-Python >=3.7,<3.11; 1.21.5 Requires-Python >=3.7,<3.11; 1.21.6 Requires-Python >=3.7,<3.11
ERROR: Could not find a version that satisfies the requirement onnxruntime>=1.12.0 (from modeci-mdf[dev]) (from versions: none)
ERROR: No matching distribution found for onnxruntime>=1.12.0

EDIT: nevermind, I see this was already brought up in #362

@pgleeson pgleeson changed the base branch from development to feature/update_onnx August 9, 2023 14:27
@pgleeson
Copy link
Member

pgleeson commented Aug 9, 2023

Mergeing this into a dedicated branch to test latest onnx version.

@pgleeson pgleeson merged commit 4897316 into feature/update_onnx Aug 9, 2023
22 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants