feat: Changed Fares Transfers to Fare Transfers #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Frequency-Based Service to Frequencies Changed logic of Pathway Signs to "One signposted_as value OR one reversed_signposted_as in pathways.txt"
Closed
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
|
Hey @qcdyx! I can't QA this yet because the test package document action fails, but some things to clarify:
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit a09c9ed 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit f043e01 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit ed0613d 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
|
Looks great on the QA side! All links work, I tested to see that Pathway Signs still triggers when only 1 of the necessary fields is added. Ready to go. |
|
@emmambd thanks for your clarification. |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 75a5652 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
|
I don't see tests for |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit c2d5c2a 📊 Notices ComparisonNew Errors (0 out of 1596 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1596 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1596 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1596 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1596 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 0811ba4 📊 Notices ComparisonNew Errors (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1601 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit a7190f6 📊 Notices ComparisonNew Errors (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1601 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1601 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory ConsumptionList of 25 datasets(memory has increased).
List of 25 datasets(memory has decreased).
List of 25 datasets(no reference available).
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 73587bf 📊 Notices ComparisonNew Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1602 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1602 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1871
I found that we are missing the logic of Pathway Connections, so I added loadPathwayConnectionsFeature method in FeedMetadata.
As per requirement of changes of the url, I found that #1877 already made the changes. @emmambd
Expected behavior:
Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything