feat: 1795 timepoint clarification #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
|
@emmambd |
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit 95fa5ee 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (533 out of 1588 datasets, ~34%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit 7eac647 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (533 out of 1588 datasets, ~34%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
jcpitre
reviewed
Oct 4, 2024
main/src/test/java/org/mobilitydata/gtfsvalidator/validator/TimepointTimeValidatorTest.java
Outdated
Show resolved
Hide resolved
jcpitre
approved these changes
Oct 4, 2024
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
1 similar comment
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
…a/gtfs-validator into 1795-timepoint-clarification
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit 432bdf5 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (532 out of 1588 datasets, ~34%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
skalexch
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
This is my first review so please make sure to merge only after @emmambd also weighs in. Everything looks good and the dropped warnings from the acceptance tests are 34% which are close to the 31% that Isabelle mentioned have timepoint missing.
The remaining 3% are the datasets that have timepoint header but do not always specify the value. Double checked with us-maryland-frederick-county-transit-gtfs-498 as well.
LGTM!
|
Thanks @skalexch! I agree. From a QA perspective, this is ready to go. |
📝 Acceptance Test Report📋 Summary❌ The rule acceptance test has failed for commit 5f5562b 📊 Notices ComparisonNew Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (532 out of 1588 datasets, ~34%) ❌Details of new errors due to code change, which is above the provided threshold of 1%.
🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1795
removed @recommended Column and modified MissingTimepointValue validation rule
Expected behavior:
test data: us-new-york-st-lawrence-county-public-transit-gtfs-5.zip
no missing_recommended_column notice on the report
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything