Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding option to pass channel type to socket #1174

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

James-Frowen
Copy link
Member

useful when using steam or epic relay and you want to use their reliability

Mirage work decide which connection type to use based on the values in SocketInfo. It will then use SendMode to tell the socket which channel it should usee for a message

SocketFactory are now required to give more information about the socket they are creating

BREAKING CHANGE: abstract MaxPacketSize property replaced with SocketInfo
BREAKING CHANGE: ISocket.Send now requires SendMode argument
useful when using steam or epic relay and you want to use their reliability

Mirage work decide which connection type to use based on the values in SocketInfo. It will then use SendMode to tell the socket which channel it should usee for a message

BREAKING CHANGE: Peer now SocketInfo to be passed in
BREAKING CHANGE: config.DisableReliableLayer removed. value is inferred from SocketInfo instead
batched message have a 2 byte length, but if socket's max size is bigger than that they could not be send. Now ArrayBatch will treat length 0 as not batched and just send the whole message to high level
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 27, 2024
@github-actions github-actions bot closed this Jul 5, 2024
@James-Frowen James-Frowen reopened this Jul 5, 2024
@James-Frowen James-Frowen added keep-open Stops issue being closed because it is stale and removed Stale labels Jul 5, 2024
@github-actions github-actions bot added the has conflicts Pull Request has merge conflicts label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts Pull Request has merge conflicts keep-open Stops issue being closed because it is stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant