Skip to content

Conversation

@saicheranb
Copy link
Contributor

@saicheranb saicheranb commented Sep 4, 2025

DEVOPS-693 - migrate from conda-lock to pixi
includes DEVOPS-889 - port RTD config of geoh5py

- Removed dynamic dependencies for 'dependencies' in favor of explicit listing.
- Consolidated dependencies under a single section for clarity.
- Added pixi configuration for project management and testing tasks.
- Updated dependency versions for h5py, numpy, Pillow, and pydantic.
- Introduced tasks for local dependency management and testing.
@github-actions github-actions bot changed the title Devops 693 : migrate from conda-lock to pixi DEVOPS-693: migrate from conda-lock to pixi Sep 4, 2025
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.99%. Comparing base (f75f211) to head (e4ad753).

Additional details and impacted files
@@               Coverage Diff                @@
##           feature/pixi     #767      +/-   ##
================================================
+ Coverage         90.96%   90.99%   +0.03%     
================================================
  Files               113      113              
  Lines              9844     9844              
  Branches           1831     1831              
================================================
+ Hits               8955     8958       +3     
+ Misses              482      478       -4     
- Partials            407      408       +1     
Files with missing lines Coverage Δ
geoh5py/data/color_map.py 92.15% <100.00%> (ø)
geoh5py/data/data.py 90.78% <100.00%> (ø)
geoh5py/data/data_type.py 95.30% <100.00%> (ø)
geoh5py/objects/curve.py 94.80% <ø> (ø)
geoh5py/objects/drape_model.py 87.35% <ø> (ø)
geoh5py/objects/surface.py 90.00% <ø> (ø)
geoh5py/shared/utils.py 91.62% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saicheranb saicheranb requested a review from sebhmg September 5, 2025 01:48
Co-authored-by: Sébastien Hensgen <sebastienh@mirageoscience.com>
Copy link
Contributor

@sebhmg sebhmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see some adjustments

- Adjusted version constraints for h5py, numpy, Pillow, and pydantic to use more specific versioning.
- Updated pixi dependencies to align with the new version specifications.
- Modified environment configurations to include 'dev' feature instead of 'dev-git'.
- Streamlined task arguments for pip commands in the pixi tasks section.
- Added jinja2 as a dependency in pyproject.toml.
- Updated the 'docs' feature group to include the 'doc' feature for Python 3.10.
Copy link
Contributor

@domfournier domfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with it if @saicheranb is ok with.

jupyter-book always creates a `_build` subfolder
Move html content to the location expected by RTD

From what I read:
- jupyter-book does not provide any option not to create that _build sub-folder
- RTD does not provide any option to tell where to look for index.html
@sebhmg
Copy link
Contributor

sebhmg commented Sep 22, 2025

@sebhmg sebhmg dismissed their stale review September 22, 2025 19:34

all requested changes applied

@sebhmg sebhmg changed the base branch from develop to feature/pixi October 24, 2025 23:31
@sebhmg sebhmg force-pushed the DEVOPS-693 branch 5 times, most recently from 347986f to 047b75a Compare October 25, 2025 04:19
resort to execution of sphinx-build after generation of conf.py

`sphinx-build` decides correctly about using ANSI colors,
while `jupyter-book build` always want them

Also needed to set PYTHONPATH from task declared in pixi:
The conf.py file generated by `jupyter-book config` does
have _ext folder added to Python path and thus loading local extension fails.
for easier debugging, as it will tell first if env can install
but cannot use it in RTD due to ANSI color codes which clutter the RTD log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants