Skip to content

Commit e1463f9

Browse files
committed
Kotlin Facet: Fix detection of pre-1.1-beta JS-stdlib dependencies
1 parent 5515a63 commit e1463f9

File tree

3 files changed

+34
-1
lines changed

3 files changed

+34
-1
lines changed

idea/src/org/jetbrains/kotlin/idea/facet/facetUtils.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ fun KotlinFacetSettings.initializeIfNeeded(module: Module, rootModel: ModuleRoot
150150
val TargetPlatformKind<*>.mavenLibraryIds: List<String>
151151
get() = when (this) {
152152
is TargetPlatformKind.Jvm -> listOf(MAVEN_STDLIB_ID, MAVEN_STDLIB_ID_JRE7, MAVEN_STDLIB_ID_JRE8)
153-
is TargetPlatformKind.JavaScript -> listOf(MAVEN_JS_STDLIB_ID)
153+
is TargetPlatformKind.JavaScript -> listOf(MAVEN_JS_STDLIB_ID, MAVEN_OLD_JS_STDLIB_ID)
154154
is TargetPlatformKind.Common -> listOf(MAVEN_COMMON_STDLIB_ID)
155155
}
156156

idea/src/org/jetbrains/kotlin/idea/versions/KotlinRuntimeLibraryUtil.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,4 +296,5 @@ val MAVEN_STDLIB_ID = "kotlin-stdlib"
296296
val MAVEN_STDLIB_ID_JRE7 = "kotlin-stdlib-jre7"
297297
val MAVEN_STDLIB_ID_JRE8 = "kotlin-stdlib-jre8"
298298
val MAVEN_JS_STDLIB_ID = "kotlin-stdlib-js"
299+
val MAVEN_OLD_JS_STDLIB_ID = "kotlin-js-library"
299300
val MAVEN_COMMON_STDLIB_ID = "kotlin-stdlib-common" // TODO: KotlinCommonMavenConfigurator

idea/tests/org/jetbrains/kotlin/idea/codeInsight/gradle/GradleFacetImportTest.kt

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,38 @@ class GradleFacetImportTest : GradleImportingTestCase() {
233233
}
234234
}*/
235235

236+
@Test
237+
fun testDetectOldJsStdlib() {
238+
createProjectSubFile("build.gradle", """
239+
group 'Again'
240+
version '1.0-SNAPSHOT'
241+
242+
buildscript {
243+
repositories {
244+
mavenCentral()
245+
maven {
246+
url 'http://dl.bintray.com/kotlin/kotlin-eap-1.1'
247+
}
248+
}
249+
250+
dependencies {
251+
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.0.6")
252+
}
253+
}
254+
255+
apply plugin: 'kotlin2js'
256+
257+
dependencies {
258+
compile "org.jetbrains.kotlin:kotlin-js-library:1.0.6"
259+
}
260+
""")
261+
importProject()
262+
263+
with (facetSettings) {
264+
Assert.assertEquals(TargetPlatformKind.JavaScript, versionInfo.targetPlatformKind)
265+
}
266+
}
267+
236268
@Test
237269
fun testCommonImport() {
238270
createProjectSubFile("build.gradle", """

0 commit comments

Comments
 (0)