Skip to content

Commit 8e9536f

Browse files
committed
Revert "Kapt3: Add generated source files to Java compile task after kapt execution. Filter only .java files."
This reverts commit 82c2ce3.
1 parent 35b41b9 commit 8e9536f

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/internal/Kapt3KotlinGradleSubplugin.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,8 @@ class Kapt3KotlinGradleSubplugin : KotlinGradleSubplugin<KotlinCompile> {
160160

161161
kaptClasspath.forEach { pluginOptions += SubpluginOption("apclasspath", it.absolutePath) }
162162

163+
javaCompile.source(generatedFilesDir)
164+
163165
pluginOptions += SubpluginOption("sources", generatedFilesDir.canonicalPath)
164166
pluginOptions += SubpluginOption("classes", getKaptClasssesDir(project, sourceSetName).canonicalPath)
165167

@@ -218,7 +220,6 @@ class Kapt3KotlinGradleSubplugin : KotlinGradleSubplugin<KotlinCompile> {
218220
val kaptTaskName = kotlinCompile.name.replaceFirst("compile", "kapt")
219221
val kaptTask = project.tasks.create(kaptTaskName, KaptTask::class.java)
220222
kaptTask.kotlinCompileTask = kotlinCompile
221-
kaptTask.javaCompileTask = javaCompile
222223
kotlinToKaptTasksMap[kotlinCompile] = kaptTask
223224

224225
project.resolveSubpluginArtifacts(listOf(this@Kapt3KotlinGradleSubplugin)).flatMap { it.value }.forEach {
@@ -233,6 +234,7 @@ class Kapt3KotlinGradleSubplugin : KotlinGradleSubplugin<KotlinCompile> {
233234

234235
// Add generated source dir as a source root for kotlinCompile and javaCompile
235236
kotlinCompile.source(sourcesOutputDir)
237+
javaCompile.source(sourcesOutputDir)
236238
variantData?.let {
237239
if (AndroidGradleWrapper.isJackEnabled(it)) {
238240
AndroidGradleWrapper.addSourceToJack(it, sourcesOutputDir)

libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/internal/KaptTask.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,15 @@ import org.jetbrains.kotlin.gradle.tasks.*
1515
import org.jetbrains.kotlin.incremental.classpathAsList
1616
import org.jetbrains.kotlin.incremental.destinationAsFile
1717
import java.io.File
18+
import java.net.URLDecoder
19+
import java.nio.charset.Charset
1820

1921
open class KaptTask : AbstractCompile() {
2022
private val rawSourceRoots = FilteringSourceRootsContainer({ !it.isInsideDestinationDir() })
2123
private val args = K2JVMCompilerArguments().apply { fillDefaultValues() }
2224

2325
internal val pluginOptions = CompilerPluginOptions()
2426
internal lateinit var kotlinCompileTask: KotlinCompile
25-
internal lateinit var javaCompileTask: AbstractCompile
2627

2728
override fun setSource(sources: Any?) {
2829
val filteredSources = rawSourceRoots.set(sources)
@@ -74,7 +75,5 @@ open class KaptTask : AbstractCompile() {
7475
val compilerRunner = GradleCompilerRunner(project)
7576
val exitCode = compilerRunner.runJvmCompiler(sourceRoots.kotlinSourceFiles, sourceRoots.javaSourceRoots, args, environment)
7677
throwGradleExceptionIfError(exitCode)
77-
78-
javaCompileTask.source(destinationDir.walkTopDown().filter { it.extension == "java" }.toList())
7978
}
8079
}

0 commit comments

Comments
 (0)