Kotlin Facet: Facet migration workaround for the case pre-1.1-beta -> 1.1.rc+ (reset useProjectSettings to false for old configurations)

asedunov · asedunov · commit 5d65e6bc9b29 · 2017-02-15T14:40:09.000+03:00
diff --git a/idea/src/org/jetbrains/kotlin/idea/facet/KotlinFacetConfiguration.kt b/idea/src/org/jetbrains/kotlin/idea/facet/KotlinFacetConfiguration.kt
@@ -46,6 +46,14 @@ class KotlinFacetConfiguration : FacetConfiguration {
         else {
             settings = KotlinFacetSettings()
         }
+
+        // Migration problem workaround for pre-1.1-beta releases (mainly 1.0.6) -> 1.1-rc+
+        // Problematic cases: 1.1-beta/1.1-beta2 -> 1.1-rc+ (useProjectSettings gets reset to false)
+        // This heuristic detects old enough configurations:
+        if (element.children.none { it.getAttribute("name").value == "useProjectSettings" }
+            && settings.compilerInfo.k2jvmCompilerArguments == null) {
+            settings.useProjectSettings = false
+        }
     }
 
     @Suppress("OverridingDeprecatedMember")

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,14 @@ class KotlinFacetConfiguration : FacetConfiguration {`
`46`	`46`	`else {`
`47`	`47`	`settings = KotlinFacetSettings()`
`48`	`48`	`}`
	`49`	`+`
	`50`	`+ // Migration problem workaround for pre-1.1-beta releases (mainly 1.0.6) -> 1.1-rc+`
	`51`	`+ // Problematic cases: 1.1-beta/1.1-beta2 -> 1.1-rc+ (useProjectSettings gets reset to false)`
	`52`	`+ // This heuristic detects old enough configurations:`
	`53`	`+ if (element.children.none { it.getAttribute("name").value == "useProjectSettings" }`
	`54`	`+ && settings.compilerInfo.k2jvmCompilerArguments == null) {`
	`55`	`+ settings.useProjectSettings = false`
	`56`	`+ }`
`49`	`57`	`}`
`50`	`58`
`51`	`59`	`@Suppress("OverridingDeprecatedMember")`