Skip to content

Commit 024aecf

Browse files
authored
Merge pull request tensorflow#18072 from jhseu/cloud_tpu_fix
Default disable including the coordinator in the TPU job
2 parents 425980c + aef7d8b commit 024aecf

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

tensorflow/contrib/cluster_resolver/python/training/tpu_cluster_resolver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def __init__(self,
7373
zone=None,
7474
project=None,
7575
job_name='worker',
76-
coordinator_name='coordinator',
76+
coordinator_name=None,
7777
coordinator_address=None,
7878
credentials='default',
7979
service=None):

tensorflow/contrib/cluster_resolver/python/training/tpu_cluster_resolver_test.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,8 @@ def testRetrieveProjectAndZoneFromMetadata(self):
117117
zone=None,
118118
tpu=['test-tpu-1'],
119119
credentials=None,
120-
service=self.mock_service_client(tpu_map=tpu_map))
120+
service=self.mock_service_client(tpu_map=tpu_map),
121+
coordinator_name='coordinator')
121122

122123
actual_cluster_spec = tpu_cluster_resolver.cluster_spec()
123124
expected_proto = """
@@ -170,6 +171,7 @@ def testSimpleSuccessfulRetrieval(self):
170171
project='test-project',
171172
zone='us-central1-c',
172173
tpu=['test-tpu-1'],
174+
coordinator_name='coordinator',
173175
coordinator_address='10.128.1.5:10203',
174176
credentials=None,
175177
service=self.mock_service_client(tpu_map=tpu_map))
@@ -196,6 +198,7 @@ def testNewNetworkEndpointFormat(self):
196198
project='test-project',
197199
zone='us-central1-c',
198200
tpu='test-tpu-1',
201+
coordinator_name='coordinator',
199202
coordinator_address='10.128.1.5:10203',
200203
credentials=None,
201204
service=self.mock_service_client(tpu_map=tpu_map))
@@ -239,7 +242,8 @@ def testPodResolution(self):
239242
tpu_cluster_resolver = TPUClusterResolver(
240243
tpu='test-tpu-1',
241244
credentials=None,
242-
service=self.mock_service_client(tpu_map=tpu_map))
245+
service=self.mock_service_client(tpu_map=tpu_map),
246+
coordinator_name='coordinator')
243247

244248
actual_cluster_spec = tpu_cluster_resolver.cluster_spec()
245249
expected_proto = """

0 commit comments

Comments
 (0)