Skip to content

Conversation

Kongolan
Copy link
Contributor

@Kongolan Kongolan commented May 4, 2019

update to mc 1.14 and fix deprecated sign api, since metadata of material sign is gone

note: i didn't add support for a sign checking the block below, since wallsign and freestanding signs are now different implementations

Copy link
Contributor

@VaiTon VaiTon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think upgrading to 1.14 right now is a good idea because of the instability of the bukkit API.

<version>3.8.0</version>
<configuration>
<source>1.8</source>
<source>1.8</source>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there so much space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messed up formatting it seems, not sure. Any ideas for the freestanding signs?

1.14 works well so far, since i'm running it on 1.14 and the very long deprecated getData() methods are now finally removed. So it needs to be changed for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants