Skip to content

Conversation

@williambl
Copy link
Contributor

@williambl williambl commented Oct 26, 2021

  • Replaces hardcoded trick creation from string with trick creation from slash command arguments
  • Re-adds arguments for tricks
  • Re-adds dedicated per-trick commands
  • Makes addtrick command not hardcoded just for string and embed trick types, so that new trick types will work
  • Adds edittrick command for editing/replacing tricks
  • Adds some util functions to make getting slash commands in a null-safe way more easy

Still needs thorough testing.

@sciwhiz12 sciwhiz12 added enhancement java Pull requests that update Java code labels Oct 26, 2021
@KiriCattus
Copy link
Contributor

Good to be merged here @williambl ? :)

@williambl williambl requested a review from TheCurle October 31, 2021 20:23
Copy link
Contributor Author

@williambl williambl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing before merge

@williambl williambl requested a review from KiriCattus November 1, 2021 01:19
@jriwanek jriwanek merged commit 6e02fca into MinecraftModDevelopment:3.0 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement hacktoberfest-accepted java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants