-
Notifications
You must be signed in to change notification settings - Fork 10
Add a scam link detector #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
williambl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the pull request, this is a much-needed feature! I have a couple of quibbles with the implementation but other than those it looks great :)
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Show resolved
Hide resolved
|
I am not sure about the channel where the logging should be done, since the only one that had something to do with deletion was the requests_deletion one |
|
Tiz the same channel, currently we don't have a deleted/edited logger in the bot because the last time we did we used D4J and have not been able to get it working since so we only logged things the bot knew it was going to delete |
sciwhiz12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots o' comments! 😄
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Outdated
Show resolved
Hide resolved
…inks) from being deleted
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/commands/bot/management/CmdRefreshScamLinks.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/commands/bot/management/CmdRefreshScamLinks.java
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Show resolved
Hide resolved
src/main/java/com/mcmoddev/mmdbot/modules/logging/misc/ScamDetector.java
Show resolved
Hide resolved
|
Is this ready to be merged? |
|
As long as @sciwhiz12 is happy (And Williambl already seems to be I think) then yeah :) If it fails to build I think there's some missing Edit: And maybe some missing license headers coz of the gradle license task not being run yet |
|
Yea the build issues are your fault :P. I had to revert to before your commits in order to actually test the bot. And I forgot about the license header |
sciwhiz12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from one quibble, this looks
to me.
All issues are marked as resolved :)
Due to the increase of scam links, this PR adds a detector for them, muting any user that sends one, and deleting their message.