Skip to content

Conversation

@Matyrobbrt
Copy link
Collaborator

Due to the increase of scam links, this PR adds a detector for them, muting any user that sends one, and deleting their message.

Copy link
Contributor

@williambl williambl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the pull request, this is a much-needed feature! I have a couple of quibbles with the implementation but other than those it looks great :)

@Matyrobbrt Matyrobbrt requested a review from williambl January 13, 2022 11:52
@Matyrobbrt
Copy link
Collaborator Author

I am not sure about the channel where the logging should be done, since the only one that had something to do with deletion was the requests_deletion one

@KiriCattus
Copy link
Contributor

Tiz the same channel, currently we don't have a deleted/edited logger in the bot because the last time we did we used D4J and have not been able to get it working since so we only logged things the bot knew it was going to delete

Copy link
Collaborator

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots o' comments! 😄

@sciwhiz12 sciwhiz12 self-requested a review January 13, 2022 23:47
@Matyrobbrt
Copy link
Collaborator Author

Is this ready to be merged?

@KiriCattus
Copy link
Contributor

KiriCattus commented Jan 23, 2022

As long as @sciwhiz12 is happy (And Williambl already seems to be I think) then yeah :) If it fails to build I think there's some missing guild issues that I had to comment out after an update to JDA recently :s

Edit: And maybe some missing license headers coz of the gradle license task not being run yet

@Matyrobbrt
Copy link
Collaborator Author

Matyrobbrt commented Jan 23, 2022

Yea the build issues are your fault :P. I had to revert to before your commits in order to actually test the bot. And I forgot about the license header

Copy link
Collaborator

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one quibble, this looks :shipit: to me.

@KiriCattus KiriCattus self-assigned this Jan 24, 2022
@KiriCattus KiriCattus dismissed williambl’s stale review January 24, 2022 12:34

All issues are marked as resolved :)

@jriwanek jriwanek merged commit 09c8ebf into MinecraftModDevelopment:3.0 Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants