Fix bots being flagged for "account too new"

Also fix a FNFE which happened when the `autoicons` folder did not exist.
Also fix the painter scheduling server icon change too late.

Author: Matyrobbrt

src/painter/java/com/mcmoddev/mmdbot/painter/ThePainter.java

@@ -150,7 +150,7 @@ public void shutdown() {
     private static Date measureNext12PMUTC() {
         final var day = OffsetDateTime.now(ZoneId.of("UTC")).plusDays(1);
         final var calendar = new GregorianCalendar(TimeZone.getTimeZone("UTC"));
-        calendar.set(day.getYear(), day.getMonthValue(), day.getDayOfMonth(), 0, 0, 0);
+        calendar.set(day.getYear(), day.getMonthValue() - 1, day.getDayOfMonth(), 0, 0, 0);
         return calendar.getTime();
     }
 }

src/painter/java/com/mcmoddev/mmdbot/painter/servericon/GenerateIconCommand.java

@@ -23,7 +23,6 @@
 import com.jagrosh.jdautilities.command.SlashCommand;
 import com.jagrosh.jdautilities.command.SlashCommandEvent;
 import com.mcmoddev.mmdbot.painter.ThePainter;
-import net.dv8tion.jda.api.Permission;
 import net.dv8tion.jda.api.entities.Icon;
 import net.dv8tion.jda.api.interactions.commands.OptionMapping;
 import net.dv8tion.jda.api.interactions.commands.OptionType;
@@ -41,9 +40,6 @@ public class GenerateIconCommand extends SlashCommand {
     public GenerateIconCommand() {
         name = "generate";
         help = "Generate an icon";
-        userPermissions = new Permission[] {
-            Permission.MANAGE_ROLES
-        };
         options = List.of(
             new OptionData(OptionType.STRING, "color", "Primary default colour for the icon", true),
             new OptionData(OptionType.STRING, "pattern-color", "Background pattern colour"),

src/painter/java/com/mcmoddev/mmdbot/painter/servericon/ServerIconCommand.java

@@ -68,9 +68,6 @@ public static final class Set extends SlashCommand {
         private Set() {
             name = "set-icon";
             help = "Set the server's icon";
-            userPermissions = new Permission[] {
-                Permission.MANAGE_ROLES
-            };
             guildOnly = true;
             options = List.of(
                 new OptionData(OptionType.ATTACHMENT, "icon", "Server icon as file", false),

src/painter/java/com/mcmoddev/mmdbot/painter/servericon/auto/AutomaticIconConfiguration.java

@@ -56,6 +56,7 @@ public static AutomaticIconConfiguration get(String guildId) throws IOException
 
     public void save(String guildId) throws IOException {
         final var path = ThePainter.getInstance().getRunPath().resolve("autoicons").resolve(guildId + ".json");
+        if (!Files.exists(path)) Files.createDirectories(path.getParent());
         try (final var writer = Files.newBufferedWriter(path)) {
             GSON.toJson(this, writer);
         }

src/painter/java/com/mcmoddev/mmdbot/painter/servericon/auto/DayCounter.java

@@ -51,7 +51,7 @@ public static DayCounter read() {
     @SneakyThrows
     public void write() {
         Path path = ThePainter.getInstance().getRunPath().resolve("autoicons/days.json");
-        Files.createDirectories(path.getParent());
+        if (!Files.exists(path)) Files.createDirectories(path.getParent());
         try (final var writer = Files.newBufferedWriter(path)) {
             AutomaticIconConfiguration.GSON.toJson(days(), writer);
         }

src/painter/java/com/mcmoddev/mmdbot/painter/servericon/auto/command/AutoIconSetCommand.java

@@ -28,6 +28,7 @@
 import com.mcmoddev.mmdbot.painter.servericon.ServerIconMaker;
 import com.mcmoddev.mmdbot.painter.servericon.auto.AutomaticIconConfiguration;
 import com.mcmoddev.mmdbot.painter.servericon.auto.DayCounter;
+import com.mcmoddev.mmdbot.painter.util.CooldownManager;
 import lombok.SneakyThrows;
 import net.dv8tion.jda.api.events.GenericEvent;
 import net.dv8tion.jda.api.events.interaction.component.ButtonInteractionEvent;
@@ -46,6 +47,7 @@
 import java.util.Comparator;
 import java.util.List;
 import java.util.Objects;
+import java.util.concurrent.TimeUnit;
 
 public class AutoIconSetCommand extends SlashCommand implements EventListener {
     public static final AutoIconSetCommand INSTANCE = new AutoIconSetCommand();
@@ -75,11 +77,18 @@ protected void execute(final SlashCommandEvent event) {
             .queue();
     }
 
+    private static final CooldownManager BUTTON_COOLDOWN = new CooldownManager(10, TimeUnit.SECONDS);
     @Override
     public void onEvent(@NotNull final GenericEvent ge) {
         if (!(ge instanceof ButtonInteractionEvent event)) return;
         if (!(Objects.equals(event.getButton().getId(), BUTTON_ID))) return;
 
+        if (!BUTTON_COOLDOWN.check(event.getUser())) {
+            event.reply("You can use this button " + BUTTON_COOLDOWN.coolDownFriendly(event.getUser()) + ".")
+                .setEphemeral(true).queue();
+            return;
+        }
+
         event.deferReply().queue();
         try {
             final var cfg = AutomaticIconConfiguration.get(event.getGuild().getId());

src/painter/java/com/mcmoddev/mmdbot/painter/util/CooldownManager.java

@@ -0,0 +1,56 @@
+/*
+ * MMDBot - https://github.com/MinecraftModDevelopment/MMDBot
+ * Copyright (C) 2016-2022 <MMD - MinecraftModDevelopment>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation;
+ * Specifically version 2.1 of the License.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301
+ * USA
+ * https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html
+ */
+package com.mcmoddev.mmdbot.painter.util;
+
+import com.github.benmanes.caffeine.cache.Cache;
+import com.github.benmanes.caffeine.cache.Caffeine;
+import net.dv8tion.jda.api.entities.User;
+import net.dv8tion.jda.api.utils.TimeFormat;
+
+import java.time.Duration;
+import java.time.Instant;
+import java.util.Objects;
+import java.util.concurrent.TimeUnit;
+
+public class CooldownManager {
+    private final Cache<Long, Instant> users;
+    private final Duration cooldownTime;
+
+    public CooldownManager(final long time, final TimeUnit unit) {
+        this.cooldownTime = Duration.of(time, unit.toChronoUnit());
+        this.users = Caffeine.newBuilder()
+            .expireAfterWrite(time, unit)
+            .build();
+    }
+
+    public boolean check(final User user) {
+        if (users.asMap().containsKey(user.getIdLong())) {
+            return false;
+        }
+        users.put(user.getIdLong(), Instant.now());
+        return true;
+    }
+
+    public String coolDownFriendly(final User user) {
+        return TimeFormat.RELATIVE.format(Objects.requireNonNull(users.getIfPresent(user.getIdLong()))
+            .plus(cooldownTime));
+    }
+}

src/watcher/java/com/mcmoddev/mmdbot/watcher/punishments/NewAccount.java

@@ -50,8 +50,8 @@ public String getReason(final GuildMemberJoinEvent event, final Member member) {
     }
 
     @Override
-    public boolean test(final GuildMemberJoinEvent guildMemberJoinEvent) {
-        return guildMemberJoinEvent.getMember()
+    public boolean test(final GuildMemberJoinEvent event) {
+        return !event.getUser().isBot() && event.getMember()
             .getTimeCreated()
             .toInstant()
             .isAfter(Instant.now() // TODO Make the threshold a config