Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate the two Material classes #49

Closed
2 tasks
tterrag1098 opened this issue Dec 17, 2019 · 1 comment
Closed
2 tasks

Differentiate the two Material classes #49

tterrag1098 opened this issue Dec 17, 2019 · 1 comment
Labels
category: class Something involving a class version: 1.16

Comments

@tterrag1098
Copy link

tterrag1098 commented Dec 17, 2019 •
edited
Loading

Having two classes called simply "Material" is a recipe for confusion. They should have different names:

  • net/minecraft/block/Material -> net/minecraft/block/PhysicsMaterial
  • net/minecraft/client/renderer/model/Material -> net/minecraft/client/renderer/model/RenderMaterial
@tterrag1098 tterrag1098 added the category: class Something involving a class label Dec 17, 2019
@jamierocks
Copy link

block/Material should stay IMO, 👍 to RenderMaterial though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: class Something involving a class version: 1.16
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LexManos @tterrag1098 @jamierocks