Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net.minecraft.world.gen.feature.AbstractSphereReplaceConfig -> CylinderReplaceFeature #117

Closed
3 tasks
alcatrazEscapee opened this issue Aug 29, 2020 · 2 comments
Labels
category: class Something involving a class

Comments

@alcatrazEscapee
Copy link

public class AbstractSphereReplaceConfig extends Feature<SphereReplaceConfig> {

This is

  • A Feature subclass, which should be suffixed with Feature, not Config
  • Not an abstract class, so it shouldn't be prefixed with Abstract
  • Generates a cylinder, not a sphere. This is obvious when looking at SphereReplaceConfig, which has a radius and ySize parameter (height).

So to fix:

  • net.minecraft.world.gen.feature.AbstractSphereReplaceConfig -> CylinderReplaceFeature

And fixing subclasses and other related classes:

  • net.minecraft.world.gen.feature.SphereReplaceFeature -> SoilDiskFeature
    • Reasoning: this is a subclass of AbstractSphereReplaceConfig, which is used for the disk_gravel, disk_clay and disk_sand configured features. It is named akin to IcePathFeature which is the other subclass of this class.
  • net.minecraft.world.gen.feature.SphereReplaceConfig -> CylinderReplaceConfig
    • Reasoning: fairly obvious change given this isn't a sphere.
@TelepathicGrunt
Copy link

Well, it's not actually a cylinder. The actual shape is called an ellipsoid so replace cylinder with ellipsoid and it'll be good to go!

@TelepathicGrunt
Copy link

ignore me. i'm wrong

@kashike kashike added the category: class Something involving a class label Dec 10, 2020
@LexManos LexManos closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: class Something involving a class
Projects
None yet
Development

No branches or pull requests

4 participants