Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net.minecraft.world.ISeedReader -> IWorldgenWorld #110

Closed
TelepathicGrunt opened this issue Aug 11, 2020 · 0 comments
Closed

net.minecraft.world.ISeedReader -> IWorldgenWorld #110

TelepathicGrunt opened this issue Aug 11, 2020 · 0 comments
Labels
category: class Something involving a class type: question Further information is requested version: 1.17

Comments

@TelepathicGrunt
Copy link

TelepathicGrunt commented Aug 11, 2020

Currently, ISeedReader is referenced all across the MC codebase (317 usages) and is often used as a way to access the world for many reasons other than just getting the seed. In fact, one of the place that it is used in is in every feature's generate method for getting/placing blocks. It is also heavily used in structures and placement code. For any new modder, the name of ISeedReader is confusing and could make them stumble trying to find where the world is in the code when ISeedReader is the world.

My suggestion is rename it to IServerWorld since ServerWorld and WorldGenRegion both implements ISeedReader and all of these are used only on serverside code. In fact, Slime entity code uses an 'instanceof ISeedReader' to make sure it is on the server as well. Any other name is welcomed as well but I think IServerWorld really nails exactly how it is being used in the codebase nicely.

Edit: changed IServerWorld to IWorldgenWorld because ISeedReader extends IServerWorld (I forgot IServerWorld was already taken). Just any name that has "world" in it would be leagues better than the current name

@LexManos LexManos added type: question Further information is requested category: class Something involving a class version: 1.17 labels Aug 12, 2020
@TelepathicGrunt TelepathicGrunt changed the title net.minecraft.world.ISeedReader -> IServerWorld net.minecraft.world.ISeedReader -> IWorldgenWorld Jan 27, 2021
@LexManos LexManos closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: class Something involving a class type: question Further information is requested version: 1.17
Projects
None yet
Development

No branches or pull requests

2 participants