net.minecraft.world.ISeedReader -> IWorldgenWorld #110
Labels
category: class
Something involving a class
type: question
Further information is requested
version: 1.17
Currently, ISeedReader is referenced all across the MC codebase (317 usages) and is often used as a way to access the world for many reasons other than just getting the seed. In fact, one of the place that it is used in is in every feature's generate method for getting/placing blocks. It is also heavily used in structures and placement code. For any new modder, the name of ISeedReader is confusing and could make them stumble trying to find where the world is in the code when ISeedReader is the world.
My suggestion is rename it to IServerWorld since ServerWorld and WorldGenRegion both implements ISeedReader and all of these are used only on serverside code. In fact, Slime entity code uses an 'instanceof ISeedReader' to make sure it is on the server as well. Any other name is welcomed as well but I think IServerWorld really nails exactly how it is being used in the codebase nicely.
Edit: changed IServerWorld to IWorldgenWorld because ISeedReader extends IServerWorld (I forgot IServerWorld was already taken). Just any name that has "world" in it would be leagues better than the current name
The text was updated successfully, but these errors were encountered: