Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net.minecraft.nbt.JsonToNBT -> SNBTParser #107

Closed
zml2008 opened this issue Aug 11, 2020 · 0 comments
Closed

net.minecraft.nbt.JsonToNBT -> SNBTParser #107

zml2008 opened this issue Aug 11, 2020 · 0 comments
Labels
category: class Something involving a class type: question Further information is requested version: 1.17

Comments

@zml2008
Copy link

zml2008 commented Aug 11, 2020

This class is a parser is for Mojang's specific string representation of NBT. While the format resembles JSON, it is not even a superset of JSON (it's more limited in which string escapes it accepts, probably other things), and should therefore not be called JSON.

The format appears to mostly be referred to as SNBT by Minecraft Wiki (though the name Mojangson has been used in the past), so calling it a SNBTParser would be more accurate and help with findability.

The static method getTagFromJson in the class would also want its name changed to match the new class name.

@kashike kashike added the category: class Something involving a class label Aug 11, 2020
@LexManos LexManos added type: question Further information is requested version: 1.17 labels Aug 11, 2020
@LexManos LexManos closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: class Something involving a class type: question Further information is requested version: 1.17
Projects
None yet
Development

No branches or pull requests

3 participants