Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SingleRandomFeature and SingleRandomFeatureConfig should be swapped #103

Closed
2 tasks
alcatrazEscapee opened this issue Aug 2, 2020 · 0 comments
Closed
2 tasks

SingleRandomFeature and SingleRandomFeatureConfig should be swapped #103

alcatrazEscapee opened this issue Aug 2, 2020 · 0 comments
Labels
category: class Something involving a class type: question Further information is requested version: 1.17

Comments

@alcatrazEscapee
Copy link

As per title, SingleRandomFeatureConfig is actually a Feature subclass, which references a IFeatureConfig implementation, SingleRandomFeature. These need to be swapped. As per #102, I will also propose these get renamed to use the Config suffix rather than the full FeatureConfig suffix.

  • net.minecraft.world.gen.feature.SingleRandomFeatureConfig -> SingleRandomFeature
  • net.minecraft.world.gen.feature.SingleRandomFeature -> SingleRandomConfig
@LexManos LexManos added type: question Further information is requested category: class Something involving a class version: 1.17 labels Aug 11, 2020
@LexManos LexManos closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: class Something involving a class type: question Further information is requested version: 1.17
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LexManos @alcatrazEscapee