add case for mina-archive to receive docker suffix tag #17540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
|
!ci-build-me |
|
!ci-nightly-me |
dkijania
commented
Jul 15, 2025
| @@ -1282,7 +1282,10 @@ function verify(){ | |||
| for network in "${__networks_arr[@]}"; do | |||
| local __artifact_full_name | |||
| __artifact_full_name=$(get_artifact_with_suffix $artifact $network) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This replicated logic from daemon. Basically we glue network name and any possible suffix like instrumented. As a result we can get:
-berkeley
-berkleey-intstrumented
-lightnet
etc
There was a problem hiding this comment.
The second is a typo I imagine? :)
dkijania
commented
Jul 15, 2025
| @@ -21,7 +21,7 @@ function export_base_image () { | |||
|
|
|||
| function export_version () { | |||
| case "${SERVICE}" in | |||
| mina-daemon|mina-batch-txn|mina-rosetta|mina-daemon-hardfork) export VERSION="${VERSION}-${NETWORK##*=}" ;; | |||
| mina-daemon|mina-archive|mina-batch-txn|mina-rosetta|mina-daemon-hardfork) export VERSION="${VERSION}-${NETWORK##*=}" ;; | |||
There was a problem hiding this comment.
Archive now get network suffix. The same as the other packages
|
!ci-nightly-me |
|
!ci-build-me |
|
!ci-bypass-changelog |
dannywillems
approved these changes
Jul 16, 2025
amc-ie
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch up docker for mina-archive. It should receive network suffix as daemon