Skip to content

Commit 5b8b806

Browse files
bkasebkase
committed
Use references instead of pointers
1 parent 5bed374 commit 5b8b806

File tree

15 files changed

+39
-44
lines changed

15 files changed

+39
-44
lines changed

‎src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libff/libff/algebra/fields/field_utils.hpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ namespace libff {
1818
// returns root of unity of order n (for n a power of 2), if one exists
1919
template<typename FieldT>
2020
typename std::enable_if<std::is_same<FieldT, Double>::value, FieldT>::type
21-
get_root_of_unity(const size_t n, bool* err);
21+
get_root_of_unity(const size_t n, bool &err);
2222

2323
template<typename FieldT>
2424
typename std::enable_if<!std::is_same<FieldT, Double>::value, FieldT>::type
25-
get_root_of_unity(const size_t n, bool* err);
25+
get_root_of_unity(const size_t n, bool &err);
2626

2727
template<typename FieldT>
2828
std::vector<FieldT> pack_int_vector_into_field_element_vector(const std::vector<size_t> &v, const size_t w);

‎src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libff/libff/algebra/fields/field_utils.tcc‎

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@
1616
#include <libff/common/double.hpp>
1717
#include <libff/common/utils.hpp>
1818

19-
#include <execinfo.h>
20-
#include <stdio.h>
21-
#include <stdlib.h>
22-
#include <unistd.h>
23-
2419
namespace libff {
2520

2621
template<typename FieldT>
@@ -31,7 +26,7 @@ FieldT coset_shift()
3126

3227
template<typename FieldT>
3328
typename std::enable_if<std::is_same<FieldT, Double>::value, FieldT>::type
34-
get_root_of_unity(const size_t n, bool* err)
29+
get_root_of_unity(const size_t n, bool &err)
3530
{
3631
const double PI = 3.141592653589793238460264338328L;
3732

@@ -44,16 +39,16 @@ get_root_of_unity(const size_t n, bool* err)
4439

4540
template<typename FieldT>
4641
typename std::enable_if<!std::is_same<FieldT, Double>::value, FieldT>::type
47-
get_root_of_unity(const size_t n, bool* err)
42+
get_root_of_unity(const size_t n, bool &err)
4843
{
4944
const size_t logn = log2(n);
5045
if (n != (1u << logn)) {
51-
*err = true;
46+
err = true;
5247
return FieldT(1,1);
5348
}
5449

5550
if (logn > FieldT::s) {
56-
*err = true;
51+
err = true;
5752
return FieldT(1,1);
5853
}
5954

‎src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libfqfft/libfqfft/evaluation_domain/domains/arithmetic_sequence_domain.hpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ namespace libfqfft {
2828
FieldT arithmetic_generator;
2929
void do_precomputation();
3030

31-
arithmetic_sequence_domain(const size_t m, bool* err);
31+
arithmetic_sequence_domain(const size_t m, bool &err);
3232

3333
void FFT(std::vector<FieldT> &a);
3434
void iFFT(std::vector<FieldT> &a);

‎src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libfqfft/libfqfft/evaluation_domain/domains/arithmetic_sequence_domain.tcc‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,16 @@
2424
namespace libfqfft {
2525

2626
template<typename FieldT>
27-
arithmetic_sequence_domain<FieldT>::arithmetic_sequence_domain(const size_t m, bool* err) : evaluation_domain<FieldT>(m)
27+
arithmetic_sequence_domain<FieldT>::arithmetic_sequence_domain(const size_t m, bool &err) : evaluation_domain<FieldT>(m)
2828
{
2929
if (m <= 1) {
30-
*err = true;
30+
err = true;
3131
precomputation_sentinel = false;
3232
return;
3333
}
3434

3535
if (FieldT::arithmetic_generator() == FieldT::zero()) {
36-
*err = true;
36+
err = true;
3737
precomputation_sentinel = false;
3838
return;
3939
}

‎src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libfqfft/libfqfft/evaluation_domain/domains/basic_radix2_domain.hpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class basic_radix2_domain : public evaluation_domain<FieldT> {
2626

2727
FieldT omega;
2828

29-
basic_radix2_domain(const size_t m, bool* err);
29+
basic_radix2_domain(const size_t m, bool &err);
3030

3131
void FFT(std::vector<FieldT> &a);
3232
void iFFT(std::vector<FieldT> &a);

‎src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libfqfft/libfqfft/evaluation_domain/domains/basic_radix2_domain.tcc‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@
2323
namespace libfqfft {
2424

2525
template<typename FieldT>
26-
basic_radix2_domain<FieldT>::basic_radix2_domain(const size_t m, bool* err) : evaluation_domain<FieldT>(m)
26+
basic_radix2_domain<FieldT>::basic_radix2_domain(const size_t m, bool &err) : evaluation_domain<FieldT>(m)
2727
{
2828
if (m <= 1) {
29-
*err = true;
29+
err = true;
3030
omega = FieldT(1,1);
3131
} else if (!std::is_same<FieldT, libff::Double>::value) {
3232
const size_t logm = libff::log2(m);
3333
if (logm > (FieldT::s)) {
34-
*err = true;
34+
err = true;
3535
omega = FieldT(1,1);
3636
} else {
3737
omega = libff::get_root_of_unity<FieldT>(m, err);

‎src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libfqfft/libfqfft/evaluation_domain/domains/basic_radix2_domain_aux.tcc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ std::vector<FieldT> _basic_radix2_evaluate_all_lagrange_polynomials(const size_t
190190
if (m != (1u << libff::log2(m))) throw DomainSizeException("expected m == (1u << log2(m))");
191191

192192
bool err = false;
193-
const FieldT omega = libff::get_root_of_unity<FieldT>(m, &err);
193+
const FieldT omega = libff::get_root_of_unity<FieldT>(m, err);
194194
if (err) {
195195
throw DomainSizeException("Failed get_root_of_unity");
196196
}

‎src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libfqfft/libfqfft/evaluation_domain/domains/extended_radix2_domain.hpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class extended_radix2_domain : public evaluation_domain<FieldT> {
2727
FieldT omega;
2828
FieldT shift;
2929

30-
extended_radix2_domain(const size_t m, bool* err);
30+
extended_radix2_domain(const size_t m, bool &err);
3131

3232
void FFT(std::vector<FieldT> &a);
3333
void iFFT(std::vector<FieldT> &a);

‎src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libfqfft/libfqfft/evaluation_domain/domains/extended_radix2_domain.tcc‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@
1818
namespace libfqfft {
1919

2020
template<typename FieldT>
21-
extended_radix2_domain<FieldT>::extended_radix2_domain(const size_t m, bool* err) : evaluation_domain<FieldT>(m)
21+
extended_radix2_domain<FieldT>::extended_radix2_domain(const size_t m, bool &err) : evaluation_domain<FieldT>(m)
2222
{
2323
if (m <= 1) {
24-
*err = true;
24+
err = true;
2525
omega = FieldT(1,1);
2626
small_m = 0;
2727
shift = FieldT(1,1);
@@ -32,7 +32,7 @@ extended_radix2_domain<FieldT>::extended_radix2_domain(const size_t m, bool* err
3232
{
3333
const size_t logm = libff::log2(m);
3434
if (logm != (FieldT::s + 1)) {
35-
*err = true;
35+
err = true;
3636
omega = FieldT(1,1);
3737
small_m = 0;
3838
shift = FieldT(1,1);

‎src/lib/snarky/src/camlsnark_c/libsnark-caml/depends/libfqfft/libfqfft/evaluation_domain/domains/geometric_sequence_domain.hpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace libfqfft {
2727
std::vector<FieldT> geometric_triangular_sequence;
2828
void do_precomputation();
2929

30-
geometric_sequence_domain(const size_t m, bool* err);
30+
geometric_sequence_domain(const size_t m, bool &err);
3131

3232
void FFT(std::vector<FieldT> &a);
3333
void iFFT(std::vector<FieldT> &a);

0 commit comments

Comments
 (0)