Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem/Bug]: Toolbar disappears either hiding all left side (bookmarks) or right side (Search, FullScreen, MoreSettings, PageSelector, PageLayout, Save, SaveAs, Print) icons. #4738

Open
setniessesed opened this issue Aug 12, 2024 · 4 comments
Assignees
Labels
bug Something isn't working tracked We are tracking this work internally.

Comments

@setniessesed
Copy link

setniessesed commented Aug 12, 2024

What happened?

Following report #2866 : Toolbar disappears either hiding all left side (bookmarks) or right side (Search, FullScreen, MoreSettings, PageSelector, PageLayout, Save, SaveAs, Print) icons.

Importance

Moderate. My app's user experience is affected, but still usable.

Runtime Channel

Stable release (WebView2 Runtime)

Runtime Version

127.0.2651.98

SDK Version

1.0.2592.51

Framework

Winforms

Operating System

Windows 11

OS Version

No response

Repro steps

  1. Using WebView2 HiddenPdfToolbarItems
  2. Hide the left-side icon of Pdf tool bar (Bookmarks)
    or, hide all right-side icons (Search, FullScreen, MoreSettings, PageSelector, PageLayout, Save, SaveAs, Print)
  3. Open a PDF file, the toolbar disappears

Repros in Edge Browser

No, issue does not reproduce in the corresponding Edge version

Regression

No, this never worked

Last working version (if regression)

No response

AB#53496551

@setniessesed setniessesed added the bug Something isn't working label Aug 12, 2024
@Master-Ukulele
Copy link

I can confirm the repo with hiding the bookmarks. Others (like hiding search) works fine, tool bar shows, and the search icon hides. Can you recheck if the problem as I described?

@setniessesed
Copy link
Author

setniessesed commented Aug 14, 2024

If I uncomment any of the commented lines below the pdf toolbar disappears.

viewer.CoreWebView2.Settings.HiddenPdfToolbarItems = //Microsoft.Web.WebView2.Core.CoreWebView2PdfToolbarItems.Bookmarks | //Microsoft.Web.WebView2.Core.CoreWebView2PdfToolbarItems.Search | Microsoft.Web.WebView2.Core.CoreWebView2PdfToolbarItems.FullScreen | Microsoft.Web.WebView2.Core.CoreWebView2PdfToolbarItems.MoreSettings | Microsoft.Web.WebView2.Core.CoreWebView2PdfToolbarItems.PageSelector | Microsoft.Web.WebView2.Core.CoreWebView2PdfToolbarItems.PageLayout | Microsoft.Web.WebView2.Core.CoreWebView2PdfToolbarItems.Save | Microsoft.Web.WebView2.Core.CoreWebView2PdfToolbarItems.SaveAs | Microsoft.Web.WebView2.Core.CoreWebView2PdfToolbarItems.Print;

So this is about hiding Bookmarks and/or Search

@Master-Ukulele
Copy link

Thanks for providing the details. It's confirmed and we'll track this issue. But now, I see the problem should be - Toolbar disappears either hiding all left side (bookmarks) or right side (Search, FullScreen, MoreSettings, PageSelector, PageLayout, Save, SaveAs, Print) icons.

Do you agree this is the correct description? And please edit the title and main content. @setniessesed @victorhuangwq

@setniessesed setniessesed changed the title [Problem/Bug]: When hidingBookmarks, Search or PageSelector the toolbar gets lost [Problem/Bug]: Toolbar disappears either hiding all left side (bookmarks) or right side (Search, FullScreen, MoreSettings, PageSelector, PageLayout, Save, SaveAs, Print) icons. Aug 27, 2024
@setniessesed
Copy link
Author

Done. As you suggested.

@Master-Ukulele Master-Ukulele added the tracked We are tracking this work internally. label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tracked We are tracking this work internally.
Projects
None yet
Development

No branches or pull requests

2 participants