Skip to content

Get-Certificate examples fixes #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 8, 2020
Merged

Get-Certificate examples fixes #1650

merged 4 commits into from
Jan 8, 2020

Conversation

Styxxy
Copy link
Contributor

@Styxxy Styxxy commented Dec 12, 2019

  • removed extra white space (lines) which makes the code sample unnecessarily long
  • removed redundant parenthesis in variable assignment
  • moved location of cli after Set-Location

Thomas Raya and others added 2 commits December 10, 2019 12:55
Publish 12/10/2019 10:33 AM PST
* removed extra white space (lines) which makes the code sample unnecessarily long
* removed redundant parenthesis in variable assignment
* moved location of cli after Set-Location
@opbld32
Copy link

opbld32 commented Dec 12, 2019

Docs Build status updates of commit 0057e1d:

🕙 Pending: waiting for processors (14 builds ahead of you)

⚠️ Docs Build is busy, currently there are 14 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

@opbld33
Copy link

opbld33 commented Dec 12, 2019

Docs Build status updates of commit 0057e1d:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/pkiclient/Get-Certificate.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Publish 12/13/2019 3:33 PM PST
@skycommand
Copy link
Contributor

skycommand commented Dec 17, 2019

Hi. If you wouldn't mind having a suggestion, I think the prompts on the page are entirely redundant. Why not get rid of all instances of "PS C:\>" and "PS cert:\LocalMachine\My>"? That'll make the page more readable.

Edit: Same goes for #1649, #1648, #1647, #1646, #1645, #1644, #1643, and #1641.

@Styxxy
Copy link
Contributor Author

Styxxy commented Dec 17, 2019

Hi. If you wouldn't mind having a suggestion, I think the prompts on the page are entirely redundant. Why not get rid of all instances of "PS C:\>" and "PS cert:\LocalMachine\My>"? That'll make the page more readable.

Edit: Same goes for #1649, #1648, #1647, #1646, #1645, #1644, #1643, and #1641.

True, but I stayed consistent with all the other snippets on all the other pages.
That's something bigger to handle than this PR.

@skycommand
Copy link
Contributor

True, but I stayed consistent with all the other snippets on all the other pages.

True, but as a principle, I'd stay away from adding the prompt when only one or two commands are shown without their output, or even when their output lacks significance. Still, it was just a suggestion. That's all.

That's something bigger to handle than this PR.

Yes, but you don't need to psych yourself out over other such stuff being in existence. As long as you're doing volunteer work here, you can change the world one click at a time. And like I said before, no pressure! It was just a suggestion.

@o0nj
Copy link
Contributor

o0nj commented Dec 23, 2019

@Styxxy Thank you for your multiple contributions overall. Would you please update the target branch of your PRs to master? We would like to proceed with the review.

@Styxxy Styxxy changed the base branch from live to master December 23, 2019 19:43
@Styxxy
Copy link
Contributor Author

Styxxy commented Dec 23, 2019

@Styxxy Thank you for your multiple contributions overall. Would you please update the target branch of your PRs to master? We would like to proceed with the review.

Interesting... I did my forking and PR's from GitHub web ui, and it defaulted to the "live" branch. (Might be the "edit" links from the docs pages that redirect to the live branch instead of the master branch?)

@e0i I switched the base branch (of the PR) to master.

@opbld34
Copy link

opbld34 commented Dec 23, 2019

Docs Build status updates of commit dbf4f7c:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/pkiclient/Get-Certificate.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@o0nj
Copy link
Contributor

o0nj commented Jan 3, 2020

@dariomws306 @get-itips

Peer review needed for this PR. Thanks.

@o0nj o0nj added the Sign off The pull request is ready to be reviewed and merged by PubOps label Jan 8, 2020
@garycentric garycentric self-assigned this Jan 8, 2020
@garycentric garycentric added the In review PubOps is reviewing the pull request label Jan 8, 2020
@garycentric garycentric merged commit d2cb6d2 into MicrosoftDocs:master Jan 8, 2020
@Styxxy Styxxy deleted the patch-16 branch January 8, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In review PubOps is reviewing the pull request Sign off The pull request is ready to be reviewed and merged by PubOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants