-
Notifications
You must be signed in to change notification settings - Fork 614
Get-Certificate examples fixes #1650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Styxxy
commented
Dec 12, 2019
- removed extra white space (lines) which makes the code sample unnecessarily long
- removed redundant parenthesis in variable assignment
- moved location of cli after Set-Location
Publish 12/10/2019 10:33 AM PST
* removed extra white space (lines) which makes the code sample unnecessarily long * removed redundant parenthesis in variable assignment * moved location of cli after Set-Location
Docs Build status updates of commit 0057e1d: 🕙 Pending: waiting for processors (14 builds ahead of you) |
Docs Build status updates of commit 0057e1d: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Publish 12/13/2019 3:33 PM PST
True, but I stayed consistent with all the other snippets on all the other pages. |
True, but as a principle, I'd stay away from adding the prompt when only one or two commands are shown without their output, or even when their output lacks significance. Still, it was just a suggestion. That's all.
Yes, but you don't need to psych yourself out over other such stuff being in existence. As long as you're doing volunteer work here, you can change the world one click at a time. And like I said before, no pressure! It was just a suggestion. |
@Styxxy Thank you for your multiple contributions overall. Would you please update the target branch of your PRs to |
Interesting... I did my forking and PR's from GitHub web ui, and it defaulted to the "live" branch. (Might be the "edit" links from the docs pages that redirect to the live branch instead of the master branch?) @e0i I switched the base branch (of the PR) to |
Docs Build status updates of commit dbf4f7c: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
@dariomws306 @get-itips Peer review needed for this PR. Thanks. |