-
Notifications
You must be signed in to change notification settings - Fork 183
Denodo: added documentation for new options in version 1.1.0 of the connector #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Denodo: added documentation for new options in version 1.1.0 of the connector #585
Conversation
Learn Build status updates of commit 0abd08b: 💡 Validation status: suggestions
powerquery-docs/connectors/media/denodo/denodo-aad-authentication.png
powerquery-docs/connectors/media/denodo/denodo-aad-authentication2.png
powerquery-docs/connectors/media/denodo/denodo-aad-authentication3.png
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PRMerger Results
|
@DougKlopfenstein - Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Validator is complaning about things like:
Should we replace those "aad" in the file names with "entraid" instead? |
You could either add "entra-id" (for example "denodo-entra-id-authentication-2.png") or just remove "aad" (for example "denodo-authentication-2.png"). Add a dash between "authentication" and the number just to be sure the name is accepted. Also be sure to change the names in the image metadata in the .md file as well. |
Learn Build status updates of commit 3a8d986: 💡 Validation status: suggestions
powerquery-docs/connectors/media/denodo/denodo-entra-id-authentication.png
powerquery-docs/connectors/media/denodo/denodo-entra-id-authentication2.png
powerquery-docs/connectors/media/denodo/denodo-entra-id-authentication3.png
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PRMerger Results
|
We didn't add a hyphen before the numbers, but it still doesn't seem to like "denodo-entra-id-authentication.png", which has no number. So it may be "id" or even "denodo" itself. Those "See documentation" links throw a 404, how can we access information about those validation rules to understand what the validator does not like? |
@denodo-research-labs Here are the Microsoft guidelines for naming files: |
Learn Build status updates of commit 5d8287a: 💡 Validation status: suggestions
powerquery-docs/connectors/media/denodo/denodo-entra-id-authentication.png
powerquery-docs/connectors/media/denodo/denodo-entra-id-authentication2.png
powerquery-docs/connectors/media/denodo/denodo-entra-id-authentication3.png
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PRMerger Results
|
Hi @denodo-research-labs - You might need to sign in when you reach the linked page. If so, the sign in should be in the upper right side of the page. If it's not there, you could try selecting the "change directory" link. Sometimes after answering the questions there it will take you to the appropriate page. Regarding the file names, it appears that there are new rules regarding image filenames. Certain abbreviations are not allowed (such as "id"). In addition, it appears that product names are considered "misspelled" and are also not allowed unless they form an actual word (so "denodo" is considered a misspelling). Note, however, that "Suggestions" don't prevent the pull request from being merged. I did a quick edit pass to update for Microsoft style, so when you are ready for this change to merge, just let me know. |
Perfect, thanks. We've been given an estimated timeline of "1 to 3 months" for the certification process of this new version to complete, so we will update when this is approved. |
This PR includes the modifications to the documentation that correspond to the new options in version 1.1.0 of the Denodo Connector, just submitted for certification.
Changes include: