-
Notifications
You must be signed in to change notification settings - Fork 844
Update multitable-lookup.md #5454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add note to clarify behaviour of displayed tables to the user.
Learn Build status updates of commit f20b1be: ✅ Validation status: passed
For more details, please refer to the build report. |
Thanks for your contribution, but I can't accept it in this location. This Multi-table lookups article is within the developer documentation for Web API. It describes how to create this type of lookup column and the supporting relationships using Web API. The comment you are adding describes the behavior of the control within a model-driven app: Note When using a Multi-table lookup on a form, only tables inside the Model-Driven App the lookup is currently in will show to the user, even if the lookup has more tables configured against it. It is a valid point, but this article isn't about model-driven apps and there is a better place to add this. This List of controls available for model-driven apps article has an Input controls section. This section describes various types of controls, but multi-table lookup columns aren't mentioned. You would need to create a new If you are willing to do this, we can keep this PR open. Otherwise, I'll close this and add it to a backlog of issues that should be addressed in the model-driven application docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my other comments about this PR
Add Multi-Table Lookup section
Revert Changes
@microsoft-github-policy-service agree |
Learn Build status updates of commit f791290: ✅ Validation status: passed
For more details, please refer to the build report. |
Learn Build status updates of commit 87a64af: ✅ Validation status: passed
For more details, please refer to the build report. |
@JimDaly That's a fair point, I've made the requested changes now. Just RE that page though, I'm unsure if that's the right place either, since the Multi-Table lookup doesn't seem to be it's own control, it just uses the standard lookup control. Granted it has the additional UI bit for selecting different tables but the Customer lookup has that as well and that's not in that section either. Also I'm unsure if Option Set should be in that list either as it's just describing the default control, not additional, unless I'm misunderstanding the point of that page. Either way let me know if you're happy with the added section, I tried to keep it similar length to other entries but can add more detail if required. |
Add note to clarify behaviour of displayed tables to the user.