Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions-infrastructure-as-code.md: missing DOCKER_REGISTRY_SERVER_* settings leads to HTTP/500 #123868

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clook
Copy link
Contributor

@clook clook commented Jul 25, 2024

Add more information about unexpected and undocumented behaviour if DOCKER_REGISTRY_SERVER_* settings are missing for a private repo reference.

Add more information about unexpected and undocumented behaviour if DOCKER_REGISTRY_SERVER_* settings are missing for a private repo reference.
Copy link
Contributor

@clook : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@clook
Copy link
Contributor Author

clook commented Jul 25, 2024

It took me more than one hour to understand this 500 error. Even if the must-have is documented, the behavior when it is not followed is not clear.

Copy link
Contributor

Learn Build status updates of commit 70e31d5:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-functions/functions-infrastructure-as-code.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Jul 25, 2024

@ggailey777

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jul 25, 2024
@ggailey777
Copy link
Contributor

Thanks @clook, but I'm going to move your info a different place (and fix the link right there that would have been helpful if it was working. I'll grab your commit so you get credit for helping out 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants