Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment-zip-push.md #123788

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Aghyad85
Copy link
Contributor

add extra details about preserved files in zip deploymet

add extra details about preserved files in zip deploymet
Copy link
Contributor

@Aghyad85 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit f07bce8:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-functions/deployment-zip-push.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Jul 18, 2024

@ggailey777

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jul 18, 2024
@@ -25,7 +25,7 @@ To speed up development, you might find it easier to deploy your function app pr
For more information, see the [.zip deployment reference](https://github.com/projectkudu/kudu/wiki/Deploying-from-a-zip-file).

>[!IMPORTANT]
> When you use .zip deployment, any files from an existing deployment that aren't found in the .zip file are deleted from your function app.
> When you use .zip deployment, any files from an existing deployment that aren't found in the .zip file are deleted from your function app.Any other files and directories found in the site that aren't being overwritten by the deployment, such as those placed there via FTP or created by your app during runtime, will be preserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bit confusing as the two sentences seem contradictory at first glance.
If I understand correctly, the first sentence states that any files not found in the zip will be deleted. The second sentence states that certain files and directories uploaded by FTP or created by the app with be preserved nonetheless. If so, let's focus the second sentence on what causes certain files/directories to be preserved.

i.e.,
"...app. However, any files and directories added to the site via FTP or by your app during runtime will be preserved."

^ Is this technically correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is correct based on the below link :

https://github.com/projectkudu/kudu/wiki/Deploying-from-a-zip-file-or-url#comparison-with-zip-api

When a new build is deployed with zipdeploy, files and directories that were created by the previous deployment(made via zipDeploy) but are no longer present in the build will be deleted. Any other files and directories found in the site that aren't being overwritten by the deployment, such as those placed there via FTP or created by your app during runtime, will be preserved. e.g. a previous folder 'BackupLogs' created from an FTP upload or manual creation would be preserved even if the zip doesn't contain this folder.

Copy link
Contributor

@im-samz im-samz Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use this?

When you use .zip deployment, any files and directories from the previous deployment that aren't found in the deployed .zip file are deleted from your function app. Files and directories that do not originate from a .zip deployment, such as those added to the site via FTP or by your app during runtime, will be preserved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ just making clear what files/directories get deleted and what gets preserved.
I don't think we need to the example for brevity sake.

@@ -25,7 +25,7 @@ To speed up development, you might find it easier to deploy your function app pr
For more information, see the [.zip deployment reference](https://github.com/projectkudu/kudu/wiki/Deploying-from-a-zip-file).

>[!IMPORTANT]
> When you use .zip deployment, any files from an existing deployment that aren't found in the .zip file are deleted from your function app.
> When you use .zip deployment, any files from an existing deployment that aren't found in the .zip file are deleted from your function app.Any other files and directories found in the site that aren't being overwritten by the deployment, such as those placed there via FTP or created by your app during runtime, will be preserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to avoid discussing FTP 😉

Suggested change
> When you use .zip deployment, any files from an existing deployment that aren't found in the .zip file are deleted from your function app.Any other files and directories found in the site that aren't being overwritten by the deployment, such as those placed there via FTP or created by your app during runtime, will be preserved.
> When you use .zip deployment, any files from the previous deployment are either deleted or updated during a subsequent deployment to your function app. Other files and directories in your function app that weren't part of the previous deployment are maintained.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants