-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment-zip-push.md #123788
base: main
Are you sure you want to change the base?
Update deployment-zip-push.md #123788
Conversation
add extra details about preserved files in zip deploymet
@Aghyad85 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit f07bce8: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
@@ -25,7 +25,7 @@ To speed up development, you might find it easier to deploy your function app pr | |||
For more information, see the [.zip deployment reference](https://github.com/projectkudu/kudu/wiki/Deploying-from-a-zip-file). | |||
|
|||
>[!IMPORTANT] | |||
> When you use .zip deployment, any files from an existing deployment that aren't found in the .zip file are deleted from your function app. | |||
> When you use .zip deployment, any files from an existing deployment that aren't found in the .zip file are deleted from your function app.Any other files and directories found in the site that aren't being overwritten by the deployment, such as those placed there via FTP or created by your app during runtime, will be preserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a bit confusing as the two sentences seem contradictory at first glance.
If I understand correctly, the first sentence states that any files not found in the zip will be deleted. The second sentence states that certain files and directories uploaded by FTP or created by the app with be preserved nonetheless. If so, let's focus the second sentence on what causes certain files/directories to be preserved.
i.e.,
"...app. However, any files and directories added to the site via FTP or by your app during runtime will be preserved."
^ Is this technically correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is correct based on the below link :
https://github.com/projectkudu/kudu/wiki/Deploying-from-a-zip-file-or-url#comparison-with-zip-api
When a new build is deployed with zipdeploy, files and directories that were created by the previous deployment(made via zipDeploy) but are no longer present in the build will be deleted. Any other files and directories found in the site that aren't being overwritten by the deployment, such as those placed there via FTP or created by your app during runtime, will be preserved. e.g. a previous folder 'BackupLogs' created from an FTP upload or manual creation would be preserved even if the zip doesn't contain this folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use this?
When you use .zip deployment, any files and directories from the previous deployment that aren't found in the deployed .zip file are deleted from your function app. Files and directories that do not originate from a .zip deployment, such as those added to the site via FTP or by your app during runtime, will be preserved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ just making clear what files/directories get deleted and what gets preserved.
I don't think we need to the example for brevity sake.
@@ -25,7 +25,7 @@ To speed up development, you might find it easier to deploy your function app pr | |||
For more information, see the [.zip deployment reference](https://github.com/projectkudu/kudu/wiki/Deploying-from-a-zip-file). | |||
|
|||
>[!IMPORTANT] | |||
> When you use .zip deployment, any files from an existing deployment that aren't found in the .zip file are deleted from your function app. | |||
> When you use .zip deployment, any files from an existing deployment that aren't found in the .zip file are deleted from your function app.Any other files and directories found in the site that aren't being overwritten by the deployment, such as those placed there via FTP or created by your app during runtime, will be preserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to avoid discussing FTP 😉
> When you use .zip deployment, any files from an existing deployment that aren't found in the .zip file are deleted from your function app.Any other files and directories found in the site that aren't being overwritten by the deployment, such as those placed there via FTP or created by your app during runtime, will be preserved. | |
> When you use .zip deployment, any files from the previous deployment are either deleted or updated during a subsequent deployment to your function app. Other files and directories in your function app that weren't part of the previous deployment are maintained. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this!
add extra details about preserved files in zip deploymet