Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we please have clearer documentation on what the failure behavior of SetConsoleMode? #276

Open
zadjii-msft opened this issue Aug 16, 2022 · 1 comment

Comments

@zadjii-msft
Copy link
Contributor

Can we please have clearer documentation in MSDN on what the failure behaviour of these functions is? For instance:

  • It's not documented whether we need to set the buffer back to the original mode on failure.
  • It's not documented what error codes we can expect to get from GetLastError and whether it's even possible to handle them (it could be any of 16000 errors!).
  • It's not documented whether buffers and their modes persist when the program exits.

I understand the need to keep suboptimal behaviour because old versions of powershell were incorrect, but I need to know about it in advance so that I can make my programs correct.

Originally posted by @Gyross in microsoft/terminal#13738 (comment)

@Gyross
Copy link

Gyross commented Aug 16, 2022

Also:

  • Which output modes are inherited when a new screen buffer is created. E.g.; I've seen ENABLE_VIRTUAL_TERMINAL_PROCESSING inherited, while other modes like ENABLE_WRAP_AT_EOL_OUTPUT are reset.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants