Use "dotnet test --verbosity" arg for console verbosity #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Faizan2304
commented
Apr 19, 2017
Faizan2304
commented
- Add support to use "dotnet test --verbosity" args for console verbosity
- Remove invalid help message
2) Remove invalid help message
|
@Faizan2304, |
singhsarab
reviewed
Apr 19, 2017
| var normalTestLogging = new List<string>() { "n", "normal", "d", "detailed", "diag", "diagnostic" }; | ||
| var minimalTestLogging = new List<string>() { "m", "minimal" }; | ||
|
|
||
| string vsTestVerbosity = "quiet"; |
There was a problem hiding this comment.
default should be minimal
singhsarab
reviewed
Apr 19, 2017
| if (!string.IsNullOrWhiteSpace(this.VSTestVerbosity) && | ||
| (string.IsNullOrEmpty(this.VSTestLogger) || this.VSTestLogger.IndexOf("console", StringComparison.OrdinalIgnoreCase) < 0)) | ||
| { | ||
| var normalTestLogging = new List<string>() { "n", "normal", "d", "detailed", "diag", "diagnostic" }; |
There was a problem hiding this comment.
Add tests for each mapping.
There was a problem hiding this comment.
Fixed in next commit.
singhsarab
approved these changes
Apr 19, 2017
smadala
approved these changes
Apr 19, 2017
| @@ -181,6 +187,25 @@ internal IEnumerable<string> CreateArgument() | |||
| } | |||
| } | |||
|
|
|||
| if (!string.IsNullOrWhiteSpace(this.VSTestVerbosity) && | |||
| (string.IsNullOrEmpty(this.VSTestLogger) || this.VSTestLogger.IndexOf("console", StringComparison.OrdinalIgnoreCase) < 0)) | |||
There was a problem hiding this comment.
use this.VSTestLogger.Startwith().
There was a problem hiding this comment.
Fixed in next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.