TRX logger Started Time fix #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t test case is default(DateTime).
|
IMHO a logger is not at liberty to decide the StartTime of a test result. It should just use the value provided by an Adapter. It is adapter's responsibility to fill in the correct value. |
|
@codito: True but don't see why the entire run should have an incorrect summary just because an adapter returns an incorrect time value in a particular scenario. This looks more of a fail safe default. |
|
@AbhitejJohn it is quite important to safe guard against crashes/reliability issues where an extension bug can jeopardize the entire platform. However not sure if it is possible for a platform to safe guard effectively w.r.t functional issues e.g. there can be a case where an adapter can send a StartTime later than a EndTime :-) |
We want to include the start up cost in the duration and remove the dependency on the StartTime stamped by the adapter.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Started time for the run, in case the start time for the first test case is default(DateTime).
Current scenario: For an Nunit Test, if the first test case is skipped test, the Start Time for that test is default(DateTime), hence the run duration comes out to be zero seconds.