-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make testhost.x86 large address aware #1986
Make testhost.x86 large address aware #1986
Conversation
b9a26fb
to
ee698c3
Compare
@sharwell , I'm trying this out locally, making sure it doesn't break UWP scenario, will get back to you by eod. |
@mayankbansal018 Thank you. I was expecting to need some sort of additional change since this pull request likely changes the output directory for these assemblies, but I was unable to decipher the build output to determine if/what the specifics were. |
@sharwell the PR doesn't change the output drop location, & I validated that even if we place testhost.dll compiled as exe for UWP projects, the tests still run fine. Just a query regarding your comment #1985 (comment), do you mean the current testhost with LAA enabled after your changes crashes, or the one w/o LAA |
Nice 👍
If I enable Server GC in the testhost.x86 that ships with Visual Studio (is not LAA), it runs out of memory.
This is a GitHub repository configuration error that I can help with. I'll send you the details on MS Teams. |
@sharwell , can you please merge the master into this branch |
I sent you a message on MS Teams internally regarding this configuration error with the details on how to resolve it.
This button would require pushing a commit to my fork of this repository. I have always intentionally disabled this for all of my pull requests, though on rare occasions I enable it for single PRs after discussion. |
Fixes #1985