Simplify SDK languages support #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on the code generation in Microsoft.NET.Test.Sdk.targets.
…et package build/* folders right beside the *.targets files that will use them.
…des instead of code generating on each build.
…re is no longer a dependency on the intermediate directory existing.
… on disk ahead of time.
…ps/targets, so they are visible to the Microsoft.NET.Test.Sdk.nuspec.
|
|
…: 3 new code files, each of which is copied into two destination folders within the package, for a new change of +6
mayankbansal018
approved these changes
Oct 19, 2018
|
@dotnet-bot test this please |
|
@plioi , can you resolve these conflicts. |
|
@mayankbansal018 I've resolved the conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing Microsoft.NET.Test.Sdk NuGet package conditionally includes a generated empty Main method for C#, F#, and VB projects so that the end user doesn't have to be concerned with that implementation detail.
There were a number of consequences handled by the *.targets file in order to properly deal with the fact that the Main methods were code generated at build time: special care to ensure the code generation happens before the files would be expected, but after their containing folder existed.
If we instead place the entry points on disk within the NuGet package:
Summary of Changes