Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data collectors present in runsettings not working when collect args are present #1510

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

abhishkk
Copy link
Contributor

Description

When few data collectors are present in runsettings and few as collect argument, then runsettings data collectors are disabled.

Example: Code coverage data collector coming form runsettings and blame data collector coming as /blame argument. Code coverage gets falsely disabled in this combination and this code coverage file is not generated.

Related issue

#1473

@abhishkk abhishkk changed the title Code coverage fix for runsettings Data collectors present in runsettings not working when collect args are present Mar 27, 2018
@abhishkk abhishkk requested a review from acesiddhu March 27, 2018 09:47
Copy link
Contributor

@mayankbansal018 mayankbansal018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@abhishkk abhishkk merged commit 9320fe1 into microsoft:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants